WordPress.org
Get WordPress

Make WordPress Core

Opened 8 months ago

Closed 8 months ago

#63432 closed defect (bug) (fixed)

Script dependency between Dashboard and Common

Reported by: sirlouen's profile SirLouen Owned by: sergeybiryukov's profile SergeyBiryukov
Milestone: 6.9 Priority: normal
Severity: trivial Version:
Component: Script Loader Keywords: dev-feedback has-patch
Focuses: Cc:

Description

Digging into #59301 I've found, by chance, that dashboard.js has a function deprecateL10nObject that depends on common.js

I don't know exactly how I got the dependency error (I was playing around with some dashboard.js defers, when it was triggered), but I think It's pretty straightforward the dependency ​checking in the dashboard.js code and ​the common.js code

Change History (3)

This ticket was mentioned in ​PR #8792 on ​WordPress/wordpress-develop by ​@SirLouen.
8 months ago #1

  • Keywords has-patch added; needs-patch removed

Simple patch to sort this dependency.

Trac ticket: https://core.trac.wordpress.org/ticket/63432

#2 @SergeyBiryukov
8 months ago

  • Milestone changed from Awaiting Review to 6.9

#3 @SergeyBiryukov
8 months ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 60241:

Script Loader: Add common.js as a dependency for dashboard.js.

dashboard.js uses the deprecateL10nObject() function, which is defined in common.js.

Follow-up to [48923], [49151].

Props SirLouen.
Fixes #63432.

Note: See TracTickets for help on using tickets.