From 5b64069ddeb87a63117d4587919bf34547e0d681 Mon Sep 17 00:00:00 2001
From: Andrea Sofia Triolo <andrea.sofia.triolo@cern.ch>
Date: Mon, 16 Mar 2026 16:06:09 +0100
Subject: [PATCH 1/2] ALICE3-TRK: add noise to the digitization process

---
 .../TRKSimulation/ChipDigitsContainer.h       |  4 ++
 .../include/TRKSimulation/DPLDigitizerParam.h |  2 +-
 .../include/TRKSimulation/DigiParams.h        |  2 +-
 .../simulation/src/ChipDigitsContainer.cxx    | 47 +++++++++++++++++++
 .../ALICE3/TRK/simulation/src/Digitizer.cxx   |  2 +-
 5 files changed, 54 insertions(+), 3 deletions(-)

diff --git a/Detectors/Upgrades/ALICE3/TRK/simulation/include/TRKSimulation/ChipDigitsContainer.h b/Detectors/Upgrades/ALICE3/TRK/simulation/include/TRKSimulation/ChipDigitsContainer.h
index 73c95b04c45e3..bf28ace0724bc 100644
--- a/Detectors/Upgrades/ALICE3/TRK/simulation/include/TRKSimulation/ChipDigitsContainer.h
+++ b/Detectors/Upgrades/ALICE3/TRK/simulation/include/TRKSimulation/ChipDigitsContainer.h
@@ -35,6 +35,10 @@ class ChipDigitsContainer : public o2::itsmft::ChipDigitsContainer
     return (static_cast<ULong64_t>(roframe) << (8 * sizeof(UInt_t))) + (static_cast<ULong64_t>(col) << (8 * sizeof(Short_t))) + row;
   }
 
+  /// Adds noise digits, deleted the one using the itsmft::DigiParams interface
+  void addNoise(UInt_t rofMin, UInt_t rofMax, const o2::itsmft::DigiParams* params, int maxRows = o2::itsmft::SegmentationAlpide::NRows, int maxCols = o2::itsmft::SegmentationAlpide::NCols) = delete;
+  void addNoise(UInt_t rofMin, UInt_t rofMax, const o2::trk::DigiParams* params, int subDetID, int layer);
+
   ClassDefNV(ChipDigitsContainer, 1);
 };
 
diff --git a/Detectors/Upgrades/ALICE3/TRK/simulation/include/TRKSimulation/DPLDigitizerParam.h b/Detectors/Upgrades/ALICE3/TRK/simulation/include/TRKSimulation/DPLDigitizerParam.h
index 15ed63e46e21f..168ae172f4b86 100644
--- a/Detectors/Upgrades/ALICE3/TRK/simulation/include/TRKSimulation/DPLDigitizerParam.h
+++ b/Detectors/Upgrades/ALICE3/TRK/simulation/include/TRKSimulation/DPLDigitizerParam.h
@@ -54,7 +54,7 @@ struct DPLDigitizerParam : public o2::conf::ConfigurableParamHelper<DPLDigitizer
  private:
   static constexpr float DEFNoisePerPixel()
   {
-    return N == o2::detectors::DetID::TRK ? 1e-8 : 1e-8; // ITS/MFT values here!!
+    return N == o2::detectors::DetID::TRK ? 1e-7 : 1e-8; // ITS/MFT values here!!
   }
 
   static constexpr std::string_view ParamName[2] = {"TRKDigitizerParam", "FT3DigitizerParam"};
diff --git a/Detectors/Upgrades/ALICE3/TRK/simulation/include/TRKSimulation/DigiParams.h b/Detectors/Upgrades/ALICE3/TRK/simulation/include/TRKSimulation/DigiParams.h
index 23824eaefa13d..d24af1bfe13f1 100644
--- a/Detectors/Upgrades/ALICE3/TRK/simulation/include/TRKSimulation/DigiParams.h
+++ b/Detectors/Upgrades/ALICE3/TRK/simulation/include/TRKSimulation/DigiParams.h
@@ -103,7 +103,7 @@ class DigiParams
  private:
   static constexpr double infTime = 1e99;
   bool mIsContinuous = false;            ///< flag for continuous simulation
-  float mNoisePerPixel = 1.e-8;          ///< ALPIDE Noise per chip
+  float mNoisePerPixel = 1.e-7;          ///< Noise per chip
   int mROFrameLengthInBC = 0;            ///< ROF length in BC for continuos mode
   float mROFrameLength = 0;              ///< length of RO frame in ns
   float mStrobeDelay = 0.;               ///< strobe start (in ns) wrt ROF start
diff --git a/Detectors/Upgrades/ALICE3/TRK/simulation/src/ChipDigitsContainer.cxx b/Detectors/Upgrades/ALICE3/TRK/simulation/src/ChipDigitsContainer.cxx
index 9ed4a4bedf5c5..32344c6470c56 100644
--- a/Detectors/Upgrades/ALICE3/TRK/simulation/src/ChipDigitsContainer.cxx
+++ b/Detectors/Upgrades/ALICE3/TRK/simulation/src/ChipDigitsContainer.cxx
@@ -15,3 +15,50 @@ using namespace o2::trk;
 
 ChipDigitsContainer::ChipDigitsContainer(UShort_t idx)
   : o2::itsmft::ChipDigitsContainer(idx) {}
+
+//______________________________________________________________________
+void ChipDigitsContainer::addNoise(UInt_t rofMin, UInt_t rofMax, const o2::trk::DigiParams* params, int subDetID, int layer)
+{
+  UInt_t row = 0;
+  UInt_t col = 0;
+  Int_t nhits = 0;
+  constexpr float ns2sec = 1e-9;
+  float mean = 0.f;
+  int nel = 0;
+  int maxRows = 0;
+  int maxCols = 0;
+
+  // TODO: set different noise and threshold for VD and MLOT
+  if (subDetID == 0) { // VD
+    maxRows = constants::VD::petal::layer::nRows[layer]; // TODO: get the layer from the geometry
+    maxCols = constants::VD::petal::layer::nCols;
+    mean = params->getNoisePerPixel() * maxRows * maxCols;
+    nel = static_cast<int>(params->getChargeThreshold() * 1.1);
+  } else { // ML/OT
+    maxRows = constants::moduleMLOT::chip::nRows;
+    maxCols = constants::moduleMLOT::chip::nCols;
+    mean = params->getNoisePerPixel() * maxRows * maxCols;
+    nel = static_cast<int>(params->getChargeThreshold() * 1.1);
+  }
+
+  LOG(debug) << "Adding noise for chip " << mChipIndex << " with mean " << mean << " and charge " << nel;
+
+  for (UInt_t rof = rofMin; rof <= rofMax; rof++) {
+    nhits = gRandom->Poisson(mean);
+    for (Int_t i = 0; i < nhits; ++i) {
+      row = gRandom->Integer(maxRows);
+      col = gRandom->Integer(maxCols);
+      LOG(debug) << "Generated noise hit at ROF " << rof << ", row " << row << ", col " << col;
+      if (mNoiseMap && mNoiseMap->isNoisy(mChipIndex, row, col)) {
+        continue;
+      }
+      if (mDeadChanMap && mDeadChanMap->isNoisy(mChipIndex, row, col)) {
+        continue;
+      }
+      auto key = getOrderingKey(rof, row, col);
+      if (!findDigit(key)) {
+        addDigit(key, rof, row, col, nel, o2::MCCompLabel(true));
+      }
+    }
+  }
+}
diff --git a/Detectors/Upgrades/ALICE3/TRK/simulation/src/Digitizer.cxx b/Detectors/Upgrades/ALICE3/TRK/simulation/src/Digitizer.cxx
index 52eaccfe045f7..31ef19a21cce9 100644
--- a/Detectors/Upgrades/ALICE3/TRK/simulation/src/Digitizer.cxx
+++ b/Detectors/Upgrades/ALICE3/TRK/simulation/src/Digitizer.cxx
@@ -215,7 +215,7 @@ void Digitizer::fillOutputContainer(uint32_t frameLast)
       if (chip.isDisabled()) {
         continue;
       }
-      // chip.addNoise(mROFrameMin, mROFrameMin, &mParams);  /// TODO: add noise
+      chip.addNoise(mROFrameMin, mROFrameMin, &mParams, mGeometry->getSubDetID(chip.getChipIndex()), mGeometry->getLayer(chip.getChipIndex())); /// TODO: add noise
       auto& buffer = chip.getPreDigits();
       if (buffer.empty()) {
         continue;

From 7a4fe8a628602df64fc3879e0d30a5d5be27656b Mon Sep 17 00:00:00 2001
From: ALICE Action Bot <alibuild@cern.ch>
Date: Mon, 16 Mar 2026 15:16:18 +0000
Subject: [PATCH 2/2] Please consider the following formatting changes

---
 .../Upgrades/ALICE3/TRK/simulation/src/ChipDigitsContainer.cxx  | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Detectors/Upgrades/ALICE3/TRK/simulation/src/ChipDigitsContainer.cxx b/Detectors/Upgrades/ALICE3/TRK/simulation/src/ChipDigitsContainer.cxx
index 32344c6470c56..d8e6df8b6099c 100644
--- a/Detectors/Upgrades/ALICE3/TRK/simulation/src/ChipDigitsContainer.cxx
+++ b/Detectors/Upgrades/ALICE3/TRK/simulation/src/ChipDigitsContainer.cxx
@@ -29,7 +29,7 @@ void ChipDigitsContainer::addNoise(UInt_t rofMin, UInt_t rofMax, const o2::trk::
   int maxCols = 0;
 
   // TODO: set different noise and threshold for VD and MLOT
-  if (subDetID == 0) { // VD
+  if (subDetID == 0) {                                   // VD
     maxRows = constants::VD::petal::layer::nRows[layer]; // TODO: get the layer from the geometry
     maxCols = constants::VD::petal::layer::nCols;
     mean = params->getNoisePerPixel() * maxRows * maxCols;