From 4f45379ad854bc1087c7bf6576c093ae4ab5a287 Mon Sep 17 00:00:00 2001 From: Jakub Juracka Date: Wed, 14 Jan 2026 17:52:08 +0100 Subject: [PATCH 1/4] changed message for medium quality --- Modules/MFT/src/QcMFTClusterCheck.cxx | 2 +- Modules/MFT/src/QcMFTDigitCheck.cxx | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/Modules/MFT/src/QcMFTClusterCheck.cxx b/Modules/MFT/src/QcMFTClusterCheck.cxx index a6a86d99a8..6a8d1cdb73 100644 --- a/Modules/MFT/src/QcMFTClusterCheck.cxx +++ b/Modules/MFT/src/QcMFTClusterCheck.cxx @@ -331,7 +331,7 @@ void QcMFTClusterCheck::beautify(std::shared_ptr mo, Quality chec msg1->SetFillColor(kOrange); msg1->Draw(); msg2->Clear(); - msg2->AddText("Write a logbook entry tagging MFT"); + msg2->AddText("Refer to QC instructions"); msg2->SetFillColor(kOrange); msg2->Draw(); } else if (checkResult == Quality::Bad) { diff --git a/Modules/MFT/src/QcMFTDigitCheck.cxx b/Modules/MFT/src/QcMFTDigitCheck.cxx index 420838229a..9a7a01fe8f 100644 --- a/Modules/MFT/src/QcMFTDigitCheck.cxx +++ b/Modules/MFT/src/QcMFTDigitCheck.cxx @@ -502,7 +502,7 @@ void QcMFTDigitCheck::beautify(std::shared_ptr mo, Quality checkR msg1->SetFillColor(kOrange); msg1->Draw(); msg2->Clear(); - msg2->AddText("Write a logbook entry tagging MFT"); + msg2->AddText("Refer to QC instructions"); msg2->SetFillColor(kOrange); msg2->Draw(); } else if (checkResult == Quality::Bad) { From 177a39937a22633d445aaf04c5a1be2db157562a Mon Sep 17 00:00:00 2001 From: Jakub Juracka Date: Wed, 14 Jan 2026 17:52:08 +0100 Subject: [PATCH 2/4] changed messages for medium quality --- Modules/MFT/src/QcMFTDigitCheck.cxx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Modules/MFT/src/QcMFTDigitCheck.cxx b/Modules/MFT/src/QcMFTDigitCheck.cxx index 9a7a01fe8f..d9fbf8c826 100644 --- a/Modules/MFT/src/QcMFTDigitCheck.cxx +++ b/Modules/MFT/src/QcMFTDigitCheck.cxx @@ -444,7 +444,7 @@ void QcMFTDigitCheck::beautify(std::shared_ptr mo, Quality checkR msg->AddText("No action needed"); } else if (mQualityMedium) { QualityColor = kOrange; - msg->AddText("Write a logbook entry tagging MFT"); + msg->AddText("Refer to QC instructions"); } else if (mQualityBad) { QualityColor = kRed; msg->AddText("Call the on-call!"); From 3ba9be8498c479270f53c452ba284e210aae8c6a Mon Sep 17 00:00:00 2001 From: Jakub Juracka Date: Thu, 12 Mar 2026 10:53:05 +0100 Subject: [PATCH 3/4] adjust quality message width --- Modules/MFT/src/QcMFTClusterCheck.cxx | 4 ++-- Modules/MFT/src/QcMFTDigitCheck.cxx | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/Modules/MFT/src/QcMFTClusterCheck.cxx b/Modules/MFT/src/QcMFTClusterCheck.cxx index fa7f6973c4..df88700413 100644 --- a/Modules/MFT/src/QcMFTClusterCheck.cxx +++ b/Modules/MFT/src/QcMFTClusterCheck.cxx @@ -306,8 +306,8 @@ void QcMFTClusterCheck::beautify(std::shared_ptr mo, Quality chec if (mo->getName().find("mClusterOccupancySummary") != std::string::npos) { auto* hOccupancySummary = dynamic_cast(mo->getObject()); - TPaveText* msg1 = new TPaveText(0.05, 0.9, 0.35, 1.0, "NDC NB"); - TPaveText* msg2 = new TPaveText(0.65, 0.9, 0.95, 1.0, "NDC NB"); + TPaveText* msg1 = new TPaveText(0.10, 0.9, 0.35, 1.0, "NDC NB"); + TPaveText* msg2 = new TPaveText(0.65, 0.9, 0.90, 1.0, "NDC NB"); hOccupancySummary->GetListOfFunctions()->Add(msg1); hOccupancySummary->GetListOfFunctions()->Add(msg2); msg1->SetName(Form("%s_msg1", mo->GetName())); diff --git a/Modules/MFT/src/QcMFTDigitCheck.cxx b/Modules/MFT/src/QcMFTDigitCheck.cxx index d9fbf8c826..0c82e025af 100644 --- a/Modules/MFT/src/QcMFTDigitCheck.cxx +++ b/Modules/MFT/src/QcMFTDigitCheck.cxx @@ -479,8 +479,8 @@ void QcMFTDigitCheck::beautify(std::shared_ptr mo, Quality checkR if (mo->getName().find("mDigitOccupancySummary") != std::string::npos) { auto* hDigitOccupancySummary = dynamic_cast(mo->getObject()); - TPaveText* msg1 = new TPaveText(0.05, 0.9, 0.35, 1.0, "NDC NB"); - TPaveText* msg2 = new TPaveText(0.65, 0.9, 0.95, 1.0, "NDC NB"); + TPaveText* msg1 = new TPaveText(0.10, 0.9, 0.35, 1.0, "NDC NB"); + TPaveText* msg2 = new TPaveText(0.65, 0.9, 0.90, 1.0, "NDC NB"); hDigitOccupancySummary->GetListOfFunctions()->Add(msg1); hDigitOccupancySummary->GetListOfFunctions()->Add(msg2); msg1->SetName(Form("%s_msg", mo->GetName())); From 67b2bd2a07139b6be6e75f9ebbbbc5911f583c93 Mon Sep 17 00:00:00 2001 From: Jakub Juracka Date: Thu, 12 Mar 2026 12:45:48 +0100 Subject: [PATCH 4/4] capitalise quality --- Modules/MFT/src/QcMFTClusterCheck.cxx | 6 +++--- Modules/MFT/src/QcMFTDigitCheck.cxx | 6 +++--- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/Modules/MFT/src/QcMFTClusterCheck.cxx b/Modules/MFT/src/QcMFTClusterCheck.cxx index df88700413..f342907a62 100644 --- a/Modules/MFT/src/QcMFTClusterCheck.cxx +++ b/Modules/MFT/src/QcMFTClusterCheck.cxx @@ -315,7 +315,7 @@ void QcMFTClusterCheck::beautify(std::shared_ptr mo, Quality chec if (checkResult == Quality::Good) { LOG(info) << "Quality::Good"; msg1->Clear(); - msg1->AddText("Quality Good"); + msg1->AddText("Quality GOOD"); msg1->SetFillColor(kGreen); msg2->Clear(); msg2->AddText("No action needed"); @@ -323,7 +323,7 @@ void QcMFTClusterCheck::beautify(std::shared_ptr mo, Quality chec } else if (checkResult == Quality::Medium) { LOG(info) << "Quality::Medium"; msg1->Clear(); - msg1->AddText("Quality medium"); + msg1->AddText("Quality MEDIUM"); msg1->SetFillColor(kOrange); msg2->Clear(); msg2->AddText("Refer to QC instructions"); @@ -331,7 +331,7 @@ void QcMFTClusterCheck::beautify(std::shared_ptr mo, Quality chec } else if (checkResult == Quality::Bad) { LOG(info) << "Quality::Bad"; msg1->Clear(); - msg1->AddText("Quality bad"); + msg1->AddText("Quality BAD"); msg1->SetFillColor(kRed); msg2->Clear(); msg2->AddText("Call the on-call!"); diff --git a/Modules/MFT/src/QcMFTDigitCheck.cxx b/Modules/MFT/src/QcMFTDigitCheck.cxx index 0c82e025af..1464679781 100644 --- a/Modules/MFT/src/QcMFTDigitCheck.cxx +++ b/Modules/MFT/src/QcMFTDigitCheck.cxx @@ -488,7 +488,7 @@ void QcMFTDigitCheck::beautify(std::shared_ptr mo, Quality checkR if (checkResult == Quality::Good) { LOG(info) << "Quality::Good"; msg1->Clear(); - msg1->AddText("Quality Good"); + msg1->AddText("Quality GOOD"); msg1->SetFillColor(kGreen); msg1->Draw(); msg2->Clear(); @@ -498,7 +498,7 @@ void QcMFTDigitCheck::beautify(std::shared_ptr mo, Quality checkR } else if (checkResult == Quality::Medium) { LOG(info) << "Quality::Medium"; msg1->Clear(); - msg1->AddText("Quality medium"); + msg1->AddText("Quality MEDIUM"); msg1->SetFillColor(kOrange); msg1->Draw(); msg2->Clear(); @@ -508,7 +508,7 @@ void QcMFTDigitCheck::beautify(std::shared_ptr mo, Quality checkR } else if (checkResult == Quality::Bad) { LOG(info) << "Quality::Bad"; msg1->Clear(); - msg1->AddText("Quality bad"); + msg1->AddText("Quality BAD"); msg1->SetFillColor(kRed); msg1->Draw(); msg2->Clear();