From d2414399fdf7d34bfd846c1d734e00c353d4eb9f Mon Sep 17 00:00:00 2001 From: James McTavish Date: Wed, 10 Aug 2022 14:28:13 -0400 Subject: [PATCH 1/2] fix: save data in /snapshot instead of /snapshots. (#56) --- src/googleclouddebugger/firebase_client.py | 2 +- tests/firebase_client_test.py | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/googleclouddebugger/firebase_client.py b/src/googleclouddebugger/firebase_client.py index 4cb414a..7dc363b 100644 --- a/src/googleclouddebugger/firebase_client.py +++ b/src/googleclouddebugger/firebase_client.py @@ -456,7 +456,7 @@ def _TransmitBreakpointUpdates(self): if is_snapshot: # Note that there may not be snapshot data. bp_ref = firebase_admin.db.reference( - f'cdbg/breakpoints/{self._debuggee_id}/snapshots/{bp_id}') + f'cdbg/breakpoints/{self._debuggee_id}/snapshot/{bp_id}') bp_ref.set(breakpoint_data) # Now strip potential snapshot data. diff --git a/tests/firebase_client_test.py b/tests/firebase_client_test.py index 1986a9a..99057f9 100644 --- a/tests/firebase_client_test.py +++ b/tests/firebase_client_test.py @@ -308,7 +308,7 @@ def testEnqueueBreakpointUpdate(self): call(f'cdbg/breakpoints/{debuggee_id}/active/{breakpoint_id}'), db_ref_calls[2]) self.assertEqual( - call(f'cdbg/breakpoints/{debuggee_id}/snapshots/{breakpoint_id}'), + call(f'cdbg/breakpoints/{debuggee_id}/snapshot/{breakpoint_id}'), db_ref_calls[3]) self.assertEqual( call(f'cdbg/breakpoints/{debuggee_id}/final/{breakpoint_id}'), @@ -381,9 +381,9 @@ def testEnqueueBreakpointUpdateWithLogpoint(self): active_ref_mock.delete.assert_called_once() final_ref_mock.set.assert_called_once_with(output_breakpoint) - # Make sure that the snapshots node was not accessed. + # Make sure that the snapshot node was not accessed. self.assertTrue( - call(f'cdbg/breakpoints/{debuggee_id}/snapshots/{breakpoint_id}') not in + call(f'cdbg/breakpoints/{debuggee_id}/snapshot/{breakpoint_id}') not in db_ref_calls) def testEnqueueBreakpointUpdateRetry(self): From 82dc9a77d42c2b4a7dee22de771e24cb65204a77 Mon Sep 17 00:00:00 2001 From: James McTavish Date: Wed, 10 Aug 2022 14:32:31 -0400 Subject: [PATCH 2/2] chore: release version 3.1 (#57) --- src/googleclouddebugger/version.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/googleclouddebugger/version.py b/src/googleclouddebugger/version.py index 30aa735..a52b8ed 100644 --- a/src/googleclouddebugger/version.py +++ b/src/googleclouddebugger/version.py @@ -4,4 +4,4 @@ # The major version should only change on breaking changes. Minor version # changes go between regular updates. Instances running debuggers with # different major versions will show up as two different debuggees. -__version__ = '3.0' +__version__ = '3.1'