Make logRetry() and logIOException() protected to allow overriding these methods in custom loggers. (OpenFeign#469)

rfalke · adriancole · commit 0e4a1c8da347 · 2016-09-29T08:48:13.000+08:00
diff --git a/core/src/main/java/feign/Logger.java b/core/src/main/java/feign/Logger.java
@@ -71,7 +71,7 @@ protected void logRequest(String configKey, Level logLevel, Request request) {
     }
   }
 
-  void logRetry(String configKey, Level logLevel) {
+  protected void logRetry(String configKey, Level logLevel) {
     log(configKey, "---> RETRYING");
   }
 
@@ -107,7 +107,7 @@ protected Response logAndRebufferResponse(String configKey, Level logLevel, Resp
     return response;
   }
 
-  IOException logIOException(String configKey, Level logLevel, IOException ioe, long elapsedTime) {
+  protected IOException logIOException(String configKey, Level logLevel, IOException ioe, long elapsedTime) {
     log(configKey, "<--- ERROR %s: %s (%sms)", ioe.getClass().getSimpleName(), ioe.getMessage(),
         elapsedTime);
     if (logLevel.ordinal() >= Level.FULL.ordinal()) {

Original file line number	Diff line number	Diff line change
`@@ -71,7 +71,7 @@ protected void logRequest(String configKey, Level logLevel, Request request) {`
`71`	`71`	`}`
`72`	`72`	`}`
`73`	`73`
`74`		`- void logRetry(String configKey, Level logLevel) {`
	`74`	`+ protected void logRetry(String configKey, Level logLevel) {`
`75`	`75`	`log(configKey, "---> RETRYING");`
`76`	`76`	`}`
`77`	`77`
`@@ -107,7 +107,7 @@ protected Response logAndRebufferResponse(String configKey, Level logLevel, Resp`
`107`	`107`	`return response;`
`108`	`108`	`}`
`109`	`109`
`110`		`- IOException logIOException(String configKey, Level logLevel, IOException ioe, long elapsedTime) {`
	`110`	`+ protected IOException logIOException(String configKey, Level logLevel, IOException ioe, long elapsedTime) {`
`111`	`111`	`log(configKey, "<--- ERROR %s: %s (%sms)", ioe.getClass().getSimpleName(), ioe.getMessage(),`
`112`	`112`	`elapsedTime);`
`113`	`113`	`if (logLevel.ordinal() >= Level.FULL.ordinal()) {`