From fde35b4aa643ee59519d02c4a49568ea9b2cbf8b Mon Sep 17 00:00:00 2001 From: vinayak Date: Wed, 6 May 2020 11:32:39 +0530 Subject: [PATCH 1/5] Create pull_request_template.md --- .github/pull_request_template.md | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) create mode 100644 .github/pull_request_template.md diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md new file mode 100644 index 0000000000..4130bfd846 --- /dev/null +++ b/.github/pull_request_template.md @@ -0,0 +1,18 @@ +# Welcome to Javascript community + +### **Describe your change:** + +* [ ] Add an algorithm? +* [ ] Fix a bug or typo in an existing algorithm? +* [ ] Documentation change? + + +### **Checklist:** +* [ ] I have read [CONTRIBUTING.md](https://github.com/TheAlgorithms/Javascript/blob/master/CONTRIBUTING.md). +* [ ] This pull request is all my own work -- I have not plagiarized. +* [ ] I know that pull requests will not be merged if they fail the automated tests. +* [ ] This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms. +* [ ] All new Javascript files are placed inside an existing directory. +* [ ] All filenames follow camel casing style. +* [ ] All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation. +* [ ] If this pull request resolves one or more open issues then the commit message contains `Fixes: #{$ISSUE_NO}`. From bea2bbc7084546bd15df33786bb70d53acd42762 Mon Sep 17 00:00:00 2001 From: vinayak Date: Wed, 6 May 2020 14:27:53 +0530 Subject: [PATCH 2/5] Update pull_request_template.md --- .github/pull_request_template.md | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index 4130bfd846..0726b4a343 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -11,8 +11,9 @@ * [ ] I have read [CONTRIBUTING.md](https://github.com/TheAlgorithms/Javascript/blob/master/CONTRIBUTING.md). * [ ] This pull request is all my own work -- I have not plagiarized. * [ ] I know that pull requests will not be merged if they fail the automated tests. -* [ ] This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms. +* [ ] This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms. * [ ] All new Javascript files are placed inside an existing directory. -* [ ] All filenames follow camel casing style. +* [ ] All filenames follow kebab-case style.There should be no spaces in filenames.
+ **Example:**`UserProfile.js` is allowed but `userprofile.js`,`Userprofile.js`,`user-Profile.js`,`userProfile.js` are not * [ ] All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation. * [ ] If this pull request resolves one or more open issues then the commit message contains `Fixes: #{$ISSUE_NO}`. From a1724da46273ed264218724726b3baab8a12ad44 Mon Sep 17 00:00:00 2001 From: vinayak Date: Wed, 6 May 2020 14:33:54 +0530 Subject: [PATCH 3/5] Update pull_request_template.md --- .github/pull_request_template.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index 0726b4a343..8ade99f575 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -13,7 +13,7 @@ * [ ] I know that pull requests will not be merged if they fail the automated tests. * [ ] This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms. * [ ] All new Javascript files are placed inside an existing directory. -* [ ] All filenames follow kebab-case style.There should be no spaces in filenames.
+* [ ] All filenames follow kebab-case style.There should be no spaces in filenames. **Example:**`UserProfile.js` is allowed but `userprofile.js`,`Userprofile.js`,`user-Profile.js`,`userProfile.js` are not * [ ] All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation. * [ ] If this pull request resolves one or more open issues then the commit message contains `Fixes: #{$ISSUE_NO}`. From 2db8e85ef382f9a66d2b99375978145e56eab65c Mon Sep 17 00:00:00 2001 From: vinayak Date: Wed, 6 May 2020 17:42:25 +0530 Subject: [PATCH 4/5] Update pull_request_template.md --- .github/pull_request_template.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index 8ade99f575..11811c3aca 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -11,9 +11,9 @@ * [ ] I have read [CONTRIBUTING.md](https://github.com/TheAlgorithms/Javascript/blob/master/CONTRIBUTING.md). * [ ] This pull request is all my own work -- I have not plagiarized. * [ ] I know that pull requests will not be merged if they fail the automated tests. -* [ ] This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms. +* [ ] This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms. * [ ] All new Javascript files are placed inside an existing directory. -* [ ] All filenames follow kebab-case style.There should be no spaces in filenames. +* [ ] All filenames follow UpperCamelCase (aka PascalCase) style. There should be no spaces in filenames. **Example:**`UserProfile.js` is allowed but `userprofile.js`,`Userprofile.js`,`user-Profile.js`,`userProfile.js` are not * [ ] All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation. * [ ] If this pull request resolves one or more open issues then the commit message contains `Fixes: #{$ISSUE_NO}`. From 9ae4b137da6fcd96fb38ddfe3c351c7bccb0172f Mon Sep 17 00:00:00 2001 From: vinayak Date: Wed, 6 May 2020 17:44:16 +0530 Subject: [PATCH 5/5] Update pull_request_template.md --- .github/pull_request_template.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index 11811c3aca..8e2674b208 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -13,7 +13,7 @@ * [ ] I know that pull requests will not be merged if they fail the automated tests. * [ ] This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms. * [ ] All new Javascript files are placed inside an existing directory. -* [ ] All filenames follow UpperCamelCase (aka PascalCase) style. There should be no spaces in filenames. +* [ ] All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames. **Example:**`UserProfile.js` is allowed but `userprofile.js`,`Userprofile.js`,`user-Profile.js`,`userProfile.js` are not * [ ] All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation. * [ ] If this pull request resolves one or more open issues then the commit message contains `Fixes: #{$ISSUE_NO}`.