This repository was archived by the owner on Sep 24, 2018. It is now read-only.
Add role to schema for users
#1400
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This way we get to supply the clients with an `enum` of roles, also the field for updating / creating a user is `role`. The maining question is whether to remove support for multiple roles or not. Currently it's half of both. Adding this PR to get the discussion moving!
Member
#1280 for discussion about this issue. Looks good to me. 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This way we get to supply the clients with an
enumof roles, also the fieldfor updating / creating a user is
role. The maining question is whether toremove support for multiple roles or not. Currently it's half of both.
Adding this PR to get the discussion moving!