56754 #3961
Closed
56754 #3961
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6.1 beta 1
costdev
requested changes
Feb 2, 2023
Contributor
costdev
left a comment
There was a problem hiding this comment.
Thanks for the PR @robinwpdeveloper!
I've left a note inline that we can't change the case of a function parameter. This means that the changes in src/wp-admin/includes/taxonomy.php (Lines 189-196) can be made here. Can you update the PR to remove all other changes? 🙂
While this PR is the same as one of the patches on the ticket, creating this PR helped to verify that no automated tests were affected by the change, so thanks for that! 👍
Author
|
Thanks @costdev |
costdev
approved these changes
Feb 2, 2023
Contributor
costdev
left a comment
There was a problem hiding this comment.
Thanks for the updates @robinwpdeveloper! LGTM 👍
Member
|
Thanks for the PR! Merged in r55190. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trac ticket: https://core.trac.wordpress.org/ticket/56754
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.