From 55540132729fc62b176817c0d8e6669790451bfb Mon Sep 17 00:00:00 2001
From: Justin Bachorik <justinbach@gmail.com>
Date: Mon, 19 Oct 2015 14:01:31 -0400
Subject: [PATCH 01/13] Update spacing from 2 to 4

---
 es5/README.md | 538 +++++++++++++++++++++++++-------------------------
 1 file changed, 269 insertions(+), 269 deletions(-)

diff --git a/es5/README.md b/es5/README.md
index 2d24f1a4a2..7c0702c71b 100644
--- a/es5/README.md
+++ b/es5/README.md
@@ -91,14 +91,14 @@
     ```javascript
     // bad
     var superman = {
-      default: { clark: 'kent' },
-      private: true
+        default: { clark: 'kent' },
+        private: true
     };
 
     // good
     var superman = {
-      defaults: { clark: 'kent' },
-      hidden: true
+        defaults: { clark: 'kent' },
+        hidden: true
     };
     ```
 
@@ -107,17 +107,17 @@
     ```javascript
     // bad
     var superman = {
-      class: 'alien'
+        class: 'alien'
     };
 
     // bad
     var superman = {
-      klass: 'alien'
+        klass: 'alien'
     };
 
     // good
     var superman = {
-      type: 'alien'
+        type: 'alien'
     };
     ```
 
@@ -157,7 +157,7 @@
 
     // bad
     for (i = 0; i < len; i++) {
-      itemsCopy[i] = items[i];
+        itemsCopy[i] = items[i];
     }
 
     // good
@@ -168,7 +168,7 @@
 
     ```javascript
     function trigger() {
-      var args = Array.prototype.slice.call(arguments);
+        var args = Array.prototype.slice.call(arguments);
       ...
     }
     ```
@@ -222,39 +222,39 @@
     var i;
 
     messages = [{
-      state: 'success',
-      message: 'This one worked.'
+        state: 'success',
+        message: 'This one worked.'
     }, {
-      state: 'success',
-      message: 'This one worked as well.'
+        state: 'success',
+        message: 'This one worked as well.'
     }, {
-      state: 'error',
-      message: 'This one did not work.'
+        state: 'error',
+        message: 'This one did not work.'
     }];
 
     length = messages.length;
 
     // bad
     function inbox(messages) {
-      items = '<ul>';
+        items = '<ul>';
 
-      for (i = 0; i < length; i++) {
-        items += '<li>' + messages[i].message + '</li>';
-      }
+        for (i = 0; i < length; i++) {
+            items += '<li>' + messages[i].message + '</li>';
+        }
 
       return items + '</ul>';
     }
 
     // good
     function inbox(messages) {
-      items = [];
+        items = [];
 
-      for (i = 0; i < length; i++) {
-        // use direct assignment in this case because we're micro-optimizing.
-        items[i] = '<li>' + messages[i].message + '</li>';
-      }
+        for (i = 0; i < length; i++) {
+            // use direct assignment in this case because we're micro-optimizing.
+            items[i] = '<li>' + messages[i].message + '</li>';
+        }
 
-      return '<ul>' + items.join('') + '</ul>';
+        return '<ul>' + items.join('') + '</ul>';
     }
     ```
 
@@ -268,17 +268,17 @@
     ```javascript
     // anonymous function expression
     var anonymous = function() {
-      return true;
+        return true;
     };
 
     // named function expression
     var named = function named() {
-      return true;
+        return true;
     };
 
     // immediately-invoked function expression (IIFE)
     (function() {
-      console.log('Welcome to the Internet. Please follow me.');
+        console.log('Welcome to the Internet. Please follow me.');
     })();
     ```
 
@@ -288,17 +288,17 @@
     ```javascript
     // bad
     if (currentUser) {
-      function test() {
-        console.log('Nope.');
-      }
+        function test() {
+            console.log('Nope.');
+        }
     }
 
     // good
     var test;
     if (currentUser) {
-      test = function test() {
-        console.log('Yup.');
-      };
+        test = function test() {
+            console.log('Yup.');
+        };
     }
     ```
 
@@ -307,12 +307,12 @@
     ```javascript
     // bad
     function nope(name, options, arguments) {
-      // ...stuff...
+        // ...stuff...
     }
 
     // good
     function yup(name, options, args) {
-      // ...stuff...
+        // ...stuff...
     }
     ```
 
@@ -326,8 +326,8 @@
 
     ```javascript
     var luke = {
-      jedi: true,
-      age: 28
+        jedi: true,
+        age: 28
     };
 
     // bad
@@ -341,12 +341,12 @@
 
     ```javascript
     var luke = {
-      jedi: true,
-      age: 28
+        jedi: true,
+        age: 28
     };
 
     function getProp(prop) {
-      return luke[prop];
+        return luke[prop];
     }
 
     var isJedi = getProp('jedi');
@@ -418,61 +418,61 @@
     ```javascript
     // bad
     function() {
-      test();
-      console.log('doing stuff..');
+        test();
+        console.log('doing stuff..');
 
-      //..other stuff..
+        //..other stuff..
 
-      var name = getName();
+        var name = getName();
 
-      if (name === 'test') {
-        return false;
-      }
+        if (name === 'test') {
+            return false;
+        }
 
-      return name;
+        return name;
     }
 
     // good
     function() {
-      var name = getName();
+        var name = getName();
 
-      test();
-      console.log('doing stuff..');
+        test();
+        console.log('doing stuff..');
 
-      //..other stuff..
+        //..other stuff..
 
-      if (name === 'test') {
-        return false;
-      }
+        if (name === 'test') {
+            return false;
+        }
 
-      return name;
+        return name;
     }
 
     // bad - unnecessary function call
     function() {
-      var name = getName();
+        var name = getName();
 
-      if (!arguments.length) {
-        return false;
-      }
+        if (!arguments.length) {
+            return false;
+        }
 
-      this.setFirstName(name);
+        this.setFirstName(name);
 
-      return true;
+        return true;
     }
 
     // good
     function() {
-      var name;
+        var name;
 
-      if (!arguments.length) {
-        return false;
-      }
+        if (!arguments.length) {
+            return false;
+        }
 
-      name = getName();
-      this.setFirstName(name);
+        name = getName();
+        this.setFirstName(name);
 
-      return true;
+        return true;
     }
     ```
 
@@ -487,7 +487,7 @@
     // we know this wouldn't work (assuming there
     // is no notDefined global variable)
     function example() {
-      console.log(notDefined); // => throws a ReferenceError
+        console.log(notDefined); // => throws a ReferenceError
     }
 
     // creating a variable declaration after you
@@ -495,17 +495,17 @@
     // variable hoisting. Note: the assignment
     // value of `true` is not hoisted.
     function example() {
-      console.log(declaredButNotAssigned); // => undefined
-      var declaredButNotAssigned = true;
+        console.log(declaredButNotAssigned); // => undefined
+        var declaredButNotAssigned = true;
     }
 
     // The interpreter is hoisting the variable
     // declaration to the top of the scope,
     // which means our example could be rewritten as:
     function example() {
-      var declaredButNotAssigned;
-      console.log(declaredButNotAssigned); // => undefined
-      declaredButNotAssigned = true;
+        var declaredButNotAssigned;
+        console.log(declaredButNotAssigned); // => undefined
+        declaredButNotAssigned = true;
     }
     ```
 
@@ -513,13 +513,13 @@
 
     ```javascript
     function example() {
-      console.log(anonymous); // => undefined
+        console.log(anonymous); // => undefined
 
-      anonymous(); // => TypeError anonymous is not a function
+        anonymous(); // => TypeError anonymous is not a function
 
-      var anonymous = function() {
-        console.log('anonymous function expression');
-      };
+        var anonymous = function() {
+            console.log('anonymous function expression');
+        };
     }
     ```
 
@@ -527,27 +527,27 @@
 
     ```javascript
     function example() {
-      console.log(named); // => undefined
+        console.log(named); // => undefined
 
-      named(); // => TypeError named is not a function
+        named(); // => TypeError named is not a function
 
-      superPower(); // => ReferenceError superPower is not defined
+        superPower(); // => ReferenceError superPower is not defined
 
-      var named = function superPower() {
-        console.log('Flying');
-      };
+        var named = function superPower() {
+            console.log('Flying');
+        };
     }
 
     // the same is true when the function name
     // is the same as the variable name.
     function example() {
-      console.log(named); // => undefined
+        console.log(named); // => undefined
 
-      named(); // => TypeError named is not a function
+        named(); // => TypeError named is not a function
 
-      var named = function named() {
-        console.log('named');
-      }
+        var named = function named() {
+            console.log('named');
+        }
     }
     ```
 
@@ -555,11 +555,11 @@
 
     ```javascript
     function example() {
-      superPower(); // => Flying
+        superPower(); // => Flying
 
-      function superPower() {
-        console.log('Flying');
-      }
+        function superPower() {
+            console.log('Flying');
+        }
     }
     ```
 
@@ -583,8 +583,8 @@
 
     ```javascript
     if ([0]) {
-      // true
-      // An array is an object, objects evaluate to true
+        // true
+        // An array is an object, objects evaluate to true
     }
     ```
 
@@ -593,22 +593,22 @@
     ```javascript
     // bad
     if (name !== '') {
-      // ...stuff...
+        // ...stuff...
     }
 
     // good
     if (name) {
-      // ...stuff...
+        // ...stuff...
     }
 
     // bad
     if (collection.length > 0) {
-      // ...stuff...
+        // ...stuff...
     }
 
     // good
     if (collection.length) {
-      // ...stuff...
+        // ...stuff...
     }
     ```
 
@@ -624,14 +624,14 @@
     ```javascript
     // bad
     if (test)
-      return false;
+        return false;
 
     // good
     if (test) return false;
 
     // good
     if (test) {
-      return false;
+        return false;
     }
 
     // bad
@@ -639,7 +639,7 @@
 
     // good
     function() {
-      return false;
+        return false;
     }
     ```
 
@@ -649,19 +649,19 @@
     ```javascript
     // bad
     if (test) {
-      thing1();
-      thing2();
+        thing1();
+        thing2();
     }
     else {
-      thing3();
+        thing3();
     }
 
     // good
     if (test) {
-      thing1();
-      thing2();
+        thing1();
+        thing2();
     } else {
-      thing3();
+        thing3();
     }
     ```
 
@@ -682,9 +682,9 @@
     // @return {Element} element
     function make(tag) {
 
-      // ...stuff...
+        // ...stuff...
 
-      return element;
+        return element;
     }
 
     // good
@@ -697,9 +697,9 @@
      */
     function make(tag) {
 
-      // ...stuff...
+        // ...stuff...
 
-      return element;
+        return element;
     }
     ```
 
@@ -715,21 +715,21 @@
 
     // bad
     function getType() {
-      console.log('fetching type...');
-      // set the default type to 'no type'
-      var type = this._type || 'no type';
+        console.log('fetching type...');
+        // set the default type to 'no type'
+        var type = this._type || 'no type';
 
-      return type;
+        return type;
     }
 
     // good
     function getType() {
-      console.log('fetching type...');
+        console.log('fetching type...');
 
-      // set the default type to 'no type'
-      var type = this._type || 'no type';
+        // set the default type to 'no type'
+        var type = this._type || 'no type';
 
-      return type;
+        return type;
     }
     ```
 
@@ -740,10 +740,10 @@
     ```javascript
     function Calculator() {
 
-      // FIXME: shouldn't use a global here
-      total = 0;
+        // FIXME: shouldn't use a global here
+        total = 0;
 
-      return this;
+        return this;
     }
     ```
 
@@ -752,10 +752,10 @@
     ```javascript
     function Calculator() {
 
-      // TODO: total should be configurable by an options param
-      this.total = 0;
+        // TODO: total should be configurable by an options param
+        this.total = 0;
 
-      return this;
+        return this;
     }
     ```
 
@@ -764,12 +764,12 @@
 
 ## Whitespace
 
-  - Use soft tabs set to 2 spaces.
+  - Use soft tabs set to 4 spaces.
 
     ```javascript
     // bad
     function() {
-    ∙∙∙∙var name;
+    ∙∙var name;
     }
 
     // bad
@@ -779,7 +779,7 @@
 
     // good
     function() {
-    ∙∙var name;
+    ∙∙∙∙var name;
     }
     ```
 
@@ -788,24 +788,24 @@
     ```javascript
     // bad
     function test(){
-      console.log('test');
+        console.log('test');
     }
 
     // good
     function test() {
-      console.log('test');
+        console.log('test');
     }
 
     // bad
     dog.set('attr',{
-      age: '1 year',
-      breed: 'Bernese Mountain Dog'
+        age: '1 year',
+        breed: 'Bernese Mountain Dog'
     });
 
     // good
     dog.set('attr', {
-      age: '1 year',
-      breed: 'Bernese Mountain Dog'
+        age: '1 year',
+        breed: 'Bernese Mountain Dog'
     });
     ```
 
@@ -814,22 +814,22 @@
     ```javascript
     // bad
     if(isJedi) {
-      fight ();
+        fight ();
     }
 
     // good
     if (isJedi) {
-      fight();
+        fight();
     }
 
     // bad
     function fight () {
-      console.log ('Swooosh!');
+        console.log ('Swooosh!');
     }
 
     // good
     function fight() {
-      console.log('Swooosh!');
+        console.log('Swooosh!');
     }
     ```
 
@@ -848,14 +848,14 @@
     ```javascript
     // bad
     (function(global) {
-      // ...stuff...
+        // ...stuff...
     })(this);
     ```
 
     ```javascript
     // bad
     (function(global) {
-      // ...stuff...
+        // ...stuff...
     })(this);↵
     ↵
     ```
@@ -863,7 +863,7 @@
     ```javascript
     // good
     (function(global) {
-      // ...stuff...
+        // ...stuff...
     })(this);↵
     ```
 
@@ -876,19 +876,19 @@
 
     // bad
     $('#items').
-      find('.selected').
-        highlight().
-        end().
-      find('.open').
-        updateCount();
+        find('.selected').
+            highlight().
+            end().
+        find('.open').
+            updateCount();
 
     // good
     $('#items')
-      .find('.selected')
-        .highlight()
-        .end()
-      .find('.open')
-        .updateCount();
+        .find('.selected')
+            .highlight()
+            .end()
+        .find('.open')
+            .updateCount();
 
     // bad
     var leds = stage.selectAll('.led').data(data).enter().append('svg:svg').classed('led', true)
@@ -900,11 +900,11 @@
     var leds = stage.selectAll('.led')
         .data(data)
       .enter().append('svg:svg')
-        .classed('led', true)
-        .attr('width', (radius + margin) * 2)
+          .classed('led', true)
+          .attr('width', (radius + margin) * 2)
       .append('svg:g')
-        .attr('transform', 'translate(' + (radius + margin) + ',' + (radius + margin) + ')')
-        .call(tron.led);
+          .attr('transform', 'translate(' + (radius + margin) + ',' + (radius + margin) + ')')
+          .call(tron.led);
     ```
 
   - Leave a blank line after blocks and before the next statement
@@ -912,33 +912,33 @@
     ```javascript
     // bad
     if (foo) {
-      return bar;
+        return bar;
     }
     return baz;
 
     // good
     if (foo) {
-      return bar;
+        return bar;
     }
 
     return baz;
 
     // bad
     var obj = {
-      foo: function() {
-      },
-      bar: function() {
-      }
+        foo: function() {
+        },
+        bar: function() {
+        }
     };
     return obj;
 
     // good
     var obj = {
-      foo: function() {
-      },
+        foo: function() {
+        },
 
-      bar: function() {
-      }
+        bar: function() {
+        }
     };
 
     return obj;
@@ -954,32 +954,32 @@
     ```javascript
     // bad
     var story = [
-        once
-      , upon
-      , aTime
+          once
+        , upon
+        , aTime
     ];
 
     // good
     var story = [
-      once,
-      upon,
-      aTime
+        once,
+        upon,
+        aTime
     ];
 
     // bad
     var hero = {
-        firstName: 'Bob'
-      , lastName: 'Parr'
-      , heroName: 'Mr. Incredible'
-      , superPower: 'strength'
+          firstName: 'Bob'
+        , lastName: 'Parr'
+        , heroName: 'Mr. Incredible'
+        , superPower: 'strength'
     };
 
     // good
     var hero = {
-      firstName: 'Bob',
-      lastName: 'Parr',
-      heroName: 'Mr. Incredible',
-      superPower: 'strength'
+        firstName: 'Bob',
+        lastName: 'Parr',
+        heroName: 'Mr. Incredible',
+        superPower: 'strength'
     };
     ```
 
@@ -990,24 +990,24 @@
     ```javascript
     // bad
     var hero = {
-      firstName: 'Kevin',
-      lastName: 'Flynn',
+        firstName: 'Kevin',
+        lastName: 'Flynn',
     };
 
     var heroes = [
-      'Batman',
-      'Superman',
+        'Batman',
+        'Superman',
     ];
 
     // good
     var hero = {
-      firstName: 'Kevin',
-      lastName: 'Flynn'
+        firstName: 'Kevin',
+        lastName: 'Flynn'
     };
 
     var heroes = [
-      'Batman',
-      'Superman'
+        'Batman',
+        'Superman'
     ];
     ```
 
@@ -1021,20 +1021,20 @@
     ```javascript
     // bad
     (function() {
-      var name = 'Skywalker'
-      return name
+        var name = 'Skywalker'
+        return name
     })()
 
     // good
     (function() {
-      var name = 'Skywalker';
-      return name;
+        var name = 'Skywalker';
+        return name;
     })();
 
     // good (guards against the function becoming an argument when two files with IIFEs are concatenated)
     ;(function() {
-      var name = 'Skywalker';
-      return name;
+        var name = 'Skywalker';
+        return name;
     })();
     ```
 
@@ -1133,12 +1133,12 @@
     ```javascript
     // bad
     function q() {
-      // ...stuff...
+        // ...stuff...
     }
 
     // good
     function query() {
-      // ..stuff..
+        // ..stuff..
     }
     ```
 
@@ -1161,20 +1161,20 @@
     ```javascript
     // bad
     function user(options) {
-      this.name = options.name;
+        this.name = options.name;
     }
 
     var bad = new user({
-      name: 'nope'
+        name: 'nope'
     });
 
     // good
     function User(options) {
-      this.name = options.name;
+        this.name = options.name;
     }
 
     var good = new User({
-      name: 'yup'
+        name: 'yup'
     });
     ```
 
@@ -1194,26 +1194,26 @@
     ```javascript
     // bad
     function() {
-      var self = this;
-      return function() {
-        console.log(self);
-      };
+        var self = this;
+        return function() {
+            console.log(self);
+        };
     }
 
     // bad
     function() {
-      var that = this;
-      return function() {
-        console.log(that);
-      };
+        var that = this;
+        return function() {
+            console.log(that);
+        };
     }
 
     // good
     function() {
-      var _this = this;
-      return function() {
-        console.log(_this);
-      };
+        var _this = this;
+        return function() {
+            console.log(_this);
+        };
     }
     ```
 
@@ -1221,13 +1221,13 @@
 
     ```javascript
     // bad
-    var log = function(msg) {
-      console.log(msg);
+    var log = function (msg) {
+        console.log(msg);
     };
 
     // good
     var log = function log(msg) {
-      console.log(msg);
+        console.log(msg);
     };
     ```
 
@@ -1279,12 +1279,12 @@
     ```javascript
     // bad
     if (!dragon.age()) {
-      return false;
+        return false;
     }
 
     // good
     if (!dragon.hasAge()) {
-      return false;
+        return false;
     }
     ```
 
@@ -1292,17 +1292,17 @@
 
     ```javascript
     function Jedi(options) {
-      options || (options = {});
-      var lightsaber = options.lightsaber || 'blue';
-      this.set('lightsaber', lightsaber);
+        options || (options = {});
+        var lightsaber = options.lightsaber || 'blue';
+        this.set('lightsaber', lightsaber);
     }
 
     Jedi.prototype.set = function(key, val) {
-      this[key] = val;
+        this[key] = val;
     };
 
     Jedi.prototype.get = function(key) {
-      return this[key];
+        return this[key];
     };
     ```
 
@@ -1315,27 +1315,27 @@
 
     ```javascript
     function Jedi() {
-      console.log('new jedi');
+        console.log('new jedi');
     }
 
     // bad
     Jedi.prototype = {
-      fight: function fight() {
-        console.log('fighting');
-      },
+        fight: function fight() {
+            console.log('fighting');
+        },
 
-      block: function block() {
-        console.log('blocking');
-      }
+        block: function block() {
+            console.log('blocking');
+        }
     };
 
     // good
     Jedi.prototype.fight = function fight() {
-      console.log('fighting');
+        console.log('fighting');
     };
 
     Jedi.prototype.block = function block() {
-      console.log('blocking');
+        console.log('blocking');
     };
     ```
 
@@ -1344,12 +1344,12 @@
     ```javascript
     // bad
     Jedi.prototype.jump = function() {
-      this.jumping = true;
-      return true;
+        this.jumping = true;
+        return true;
     };
 
     Jedi.prototype.setHeight = function(height) {
-      this.height = height;
+        this.height = height;
     };
 
     var luke = new Jedi();
@@ -1358,19 +1358,19 @@
 
     // good
     Jedi.prototype.jump = function() {
-      this.jumping = true;
-      return this;
+        this.jumping = true;
+        return this;
     };
 
     Jedi.prototype.setHeight = function(height) {
-      this.height = height;
-      return this;
+        this.height = height;
+        return this;
     };
 
     var luke = new Jedi();
 
     luke.jump()
-      .setHeight(20);
+        .setHeight(20);
     ```
 
 
@@ -1378,16 +1378,16 @@
 
     ```javascript
     function Jedi(options) {
-      options || (options = {});
-      this.name = options.name || 'no name';
+        options || (options = {});
+        this.name = options.name || 'no name';
     }
 
     Jedi.prototype.getName = function getName() {
-      return this.name;
+        return this.name;
     };
 
     Jedi.prototype.toString = function toString() {
-      return 'Jedi - ' + this.getName();
+        return 'Jedi - ' + this.getName();
     };
     ```
 
@@ -1405,7 +1405,7 @@
     ...
 
     $(this).on('listingUpdated', function(e, listingId) {
-      // do something with listingId
+        // do something with listingId
     });
     ```
 
@@ -1418,7 +1418,7 @@
     ...
 
     $(this).on('listingUpdated', function(e, data) {
-      // do something with data.listingId
+        // do something with data.listingId
     });
     ```
 
@@ -1436,18 +1436,18 @@
     // fancyInput/fancyInput.js
 
     !function(global) {
-      'use strict';
+        'use strict';
 
-      var previousFancyInput = global.FancyInput;
+        var previousFancyInput = global.FancyInput;
 
-      function FancyInput(options) {
-        this.options = options || {};
-      }
+        function FancyInput(options) {
+            this.options = options || {};
+        }
 
-      FancyInput.noConflict = function noConflict() {
-        global.FancyInput = previousFancyInput;
-        return FancyInput;
-      };
+        FancyInput.noConflict = function noConflict() {
+            global.FancyInput = previousFancyInput;
+            return FancyInput;
+        };
 
       global.FancyInput = FancyInput;
     }(this);
@@ -1473,25 +1473,25 @@
     ```javascript
     // bad
     function setSidebar() {
-      $('.sidebar').hide();
+        $('.sidebar').hide();
 
-      // ...stuff...
+        // ...stuff...
 
-      $('.sidebar').css({
-        'background-color': 'pink'
-      });
+        $('.sidebar').css({
+            'background-color': 'pink'
+        });
     }
 
     // good
     function setSidebar() {
-      var $sidebar = $('.sidebar');
-      $sidebar.hide();
+        var $sidebar = $('.sidebar');
+        $sidebar.hide();
 
-      // ...stuff...
+        // ...stuff...
 
-      $sidebar.css({
-        'background-color': 'pink'
-      });
+        $sidebar.css({
+            'background-color': 'pink'
+        });
     }
     ```
 
@@ -1531,7 +1531,7 @@
 
     ```javascript
     function() {
-      return true;
+        return true;
     }
     ```
 

From 0a6280f178a1a1cfaec6524558bfcbbb4f39992d Mon Sep 17 00:00:00 2001
From: Justin Bachorik <justinbach@gmail.com>
Date: Mon, 19 Oct 2015 14:05:10 -0400
Subject: [PATCH 02/13] Add space between function and ( in anonymous
 definitions

---
 es5/README.md | 78 +++++++++++++++++++++++++--------------------------
 1 file changed, 39 insertions(+), 39 deletions(-)

diff --git a/es5/README.md b/es5/README.md
index 7c0702c71b..7940fa8157 100644
--- a/es5/README.md
+++ b/es5/README.md
@@ -267,7 +267,7 @@
 
     ```javascript
     // anonymous function expression
-    var anonymous = function() {
+    var anonymous = function () {
         return true;
     };
 
@@ -277,7 +277,7 @@
     };
 
     // immediately-invoked function expression (IIFE)
-    (function() {
+    (function () {
         console.log('Welcome to the Internet. Please follow me.');
     })();
     ```
@@ -417,7 +417,7 @@
 
     ```javascript
     // bad
-    function() {
+    function () {
         test();
         console.log('doing stuff..');
 
@@ -433,7 +433,7 @@
     }
 
     // good
-    function() {
+    function () {
         var name = getName();
 
         test();
@@ -449,7 +449,7 @@
     }
 
     // bad - unnecessary function call
-    function() {
+    function () {
         var name = getName();
 
         if (!arguments.length) {
@@ -462,7 +462,7 @@
     }
 
     // good
-    function() {
+    function () {
         var name;
 
         if (!arguments.length) {
@@ -517,7 +517,7 @@
 
         anonymous(); // => TypeError anonymous is not a function
 
-        var anonymous = function() {
+        var anonymous = function () {
             console.log('anonymous function expression');
         };
     }
@@ -635,10 +635,10 @@
     }
 
     // bad
-    function() { return false; }
+    function () { return false; }
 
     // good
-    function() {
+    function () {
         return false;
     }
     ```
@@ -768,17 +768,17 @@
 
     ```javascript
     // bad
-    function() {
+    function () {
     ∙∙var name;
     }
 
     // bad
-    function() {
+    function () {
     ∙var name;
     }
 
     // good
-    function() {
+    function () {
     ∙∙∙∙var name;
     }
     ```
@@ -847,14 +847,14 @@
 
     ```javascript
     // bad
-    (function(global) {
+    (function (global) {
         // ...stuff...
     })(this);
     ```
 
     ```javascript
     // bad
-    (function(global) {
+    (function (global) {
         // ...stuff...
     })(this);↵
     ↵
@@ -862,7 +862,7 @@
 
     ```javascript
     // good
-    (function(global) {
+    (function (global) {
         // ...stuff...
     })(this);↵
     ```
@@ -925,19 +925,19 @@
 
     // bad
     var obj = {
-        foo: function() {
+        foo: function () {
         },
-        bar: function() {
+        bar: function () {
         }
     };
     return obj;
 
     // good
     var obj = {
-        foo: function() {
+        foo: function () {
         },
 
-        bar: function() {
+        bar: function () {
         }
     };
 
@@ -1020,19 +1020,19 @@
 
     ```javascript
     // bad
-    (function() {
+    (function () {
         var name = 'Skywalker'
         return name
     })()
 
     // good
-    (function() {
+    (function () {
         var name = 'Skywalker';
         return name;
     })();
 
     // good (guards against the function becoming an argument when two files with IIFEs are concatenated)
-    ;(function() {
+    ;(function () {
         var name = 'Skywalker';
         return name;
     })();
@@ -1153,7 +1153,7 @@
 
     // good
     var thisIsMyObject = {};
-    function thisIsMyFunction() {}
+    function thisIsMyFunction () {}
     ```
 
   - Use PascalCase when naming constructors or classes.
@@ -1193,25 +1193,25 @@
 
     ```javascript
     // bad
-    function() {
+    function () {
         var self = this;
-        return function() {
+        return function () {
             console.log(self);
         };
     }
 
     // bad
-    function() {
+    function () {
         var that = this;
-        return function() {
+        return function () {
             console.log(that);
         };
     }
 
     // good
-    function() {
+    function () {
         var _this = this;
-        return function() {
+        return function () {
             console.log(_this);
         };
     }
@@ -1297,11 +1297,11 @@
         this.set('lightsaber', lightsaber);
     }
 
-    Jedi.prototype.set = function(key, val) {
+    Jedi.prototype.set = function (key, val) {
         this[key] = val;
     };
 
-    Jedi.prototype.get = function(key) {
+    Jedi.prototype.get = function (key) {
         return this[key];
     };
     ```
@@ -1343,12 +1343,12 @@
 
     ```javascript
     // bad
-    Jedi.prototype.jump = function() {
+    Jedi.prototype.jump = function () {
         this.jumping = true;
         return true;
     };
 
-    Jedi.prototype.setHeight = function(height) {
+    Jedi.prototype.setHeight = function (height) {
         this.height = height;
     };
 
@@ -1357,12 +1357,12 @@
     luke.setHeight(20); // => undefined
 
     // good
-    Jedi.prototype.jump = function() {
+    Jedi.prototype.jump = function () {
         this.jumping = true;
         return this;
     };
 
-    Jedi.prototype.setHeight = function(height) {
+    Jedi.prototype.setHeight = function (height) {
         this.height = height;
         return this;
     };
@@ -1404,7 +1404,7 @@
 
     ...
 
-    $(this).on('listingUpdated', function(e, listingId) {
+    $(this).on('listingUpdated', function (e, listingId) {
         // do something with listingId
     });
     ```
@@ -1417,7 +1417,7 @@
 
     ...
 
-    $(this).on('listingUpdated', function(e, data) {
+    $(this).on('listingUpdated', function (e, data) {
         // do something with data.listingId
     });
     ```
@@ -1435,7 +1435,7 @@
     ```javascript
     // fancyInput/fancyInput.js
 
-    !function(global) {
+    !function (global) {
         'use strict';
 
         var previousFancyInput = global.FancyInput;
@@ -1530,7 +1530,7 @@
   - **Yup.**
 
     ```javascript
-    function() {
+    function () {
         return true;
     }
     ```

From 333b1ca4bbe85f54b526def0d50e0090dc55e8de Mon Sep 17 00:00:00 2001
From: Justin Bachorik <justinbach@gmail.com>
Date: Mon, 19 Oct 2015 14:07:33 -0400
Subject: [PATCH 03/13] Update title and description

---
 es5/README.md | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/es5/README.md b/es5/README.md
index 7940fa8157..2a1e7bfb64 100644
--- a/es5/README.md
+++ b/es5/README.md
@@ -1,8 +1,8 @@
 [![Gitter](https://badges.gitter.im/Join Chat.svg)](https://gitter.im/airbnb/javascript?utm_source=badge&utm_medium=badge&utm_campaign=pr-badge)
 
-# Airbnb JavaScript Style Guide() {
+# NPRDM JavaScript Style Guide() {
 
-*A mostly reasonable approach to JavaScript*
+*A mostly reasonable approach to JavaScript, ~~shamelessly stolen~~ borrowed heavily from AirBnB*
 
 
 ## Table of Contents

From f91f12c407446b1d6cfe88b5ef4e937db9925439 Mon Sep 17 00:00:00 2001
From: Stephen Thompson <scthompson@npr.org>
Date: Tue, 20 Oct 2015 11:36:52 -0400
Subject: [PATCH 04/13] Change module rules to be much less strict and to use
 kebab case rather than camel case.

---
 es5/README.md | 26 +-------------------------
 1 file changed, 1 insertion(+), 25 deletions(-)

diff --git a/es5/README.md b/es5/README.md
index 2a1e7bfb64..d4665d389f 100644
--- a/es5/README.md
+++ b/es5/README.md
@@ -1427,31 +1427,7 @@
 
 ## Modules
 
-  - The module should start with a `!`. This ensures that if a malformed module forgets to include a final semicolon there aren't errors in production when the scripts get concatenated. [Explanation](https://github.com/airbnb/javascript/issues/44#issuecomment-13063933)
-  - The file should be named with camelCase, live in a folder with the same name, and match the name of the single export.
-  - Add a method called `noConflict()` that sets the exported module to the previous version and returns this one.
-  - Always declare `'use strict';` at the top of the module.
-
-    ```javascript
-    // fancyInput/fancyInput.js
-
-    !function (global) {
-        'use strict';
-
-        var previousFancyInput = global.FancyInput;
-
-        function FancyInput(options) {
-            this.options = options || {};
-        }
-
-        FancyInput.noConflict = function noConflict() {
-            global.FancyInput = previousFancyInput;
-            return FancyInput;
-        };
-
-      global.FancyInput = FancyInput;
-    }(this);
-    ```
+  - The file should be named with kebab-case.
 
 **[⬆ back to top](#table-of-contents)**
 

From 8a328b2071ff02c91ee3c4c2e00ec84763b6fc46 Mon Sep 17 00:00:00 2001
From: Justin Bachorik <justinbach@gmail.com>
Date: Thu, 29 Oct 2015 16:42:43 -0400
Subject: [PATCH 05/13] Documentation review feedback

---
 es5/README.md | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/es5/README.md b/es5/README.md
index d4665d389f..0c1fd49381 100644
--- a/es5/README.md
+++ b/es5/README.md
@@ -120,6 +120,7 @@
         type: 'alien'
     };
     ```
+  - Use camelCase when naming properties of objects, including methods. Properties and methods that should be regarded as private to the object should be named using _camelCase (i.e. with a leading underscore).
 
 **[⬆ back to top](#table-of-contents)**
 
@@ -1426,8 +1427,8 @@
 
 
 ## Modules
-
-  - The file should be named with kebab-case.
+  - Always declare `'use strict';` at the top of the module.
+  - The file containing a module should be named with kebab-case.
 
 **[⬆ back to top](#table-of-contents)**
 

From 6fa05f0fad96bf117d7560b7588c80d2e0618350 Mon Sep 17 00:00:00 2001
From: Stephen Thompson <scthompson@npr.org>
Date: Sun, 8 Nov 2015 21:29:16 -0500
Subject: [PATCH 06/13] Bring jshintrc in line with standards

---
 linters/jshintrc | 33 +++++++++++++++------------------
 1 file changed, 15 insertions(+), 18 deletions(-)

diff --git a/linters/jshintrc b/linters/jshintrc
index 141067fd23..95fb15ca2b 100644
--- a/linters/jshintrc
+++ b/linters/jshintrc
@@ -10,38 +10,35 @@
   // Define globals exposed by jQuery.
   "jquery": true,
 
-  // Define globals exposed by Node.js.
-  "node": true,
+  // Define globals exposed by Mocha.
+  "mocha": true,
 
-  // Allow ES6.
-  "esnext": true,
+  // Don't allow ES6 -- yet.
+  "esnext": false,
 
   /*
    * ENFORCING OPTIONS
    * =================
    */
-
-  // Force all variable names to use either camelCase style or UPPER_CASE
-  // with underscores.
-  "camelcase": true,
+   // Don't enforce code style since those rules will be deprecated in JSHint.
 
   // Prohibit use of == and != in favor of === and !==.
   "eqeqeq": true,
 
-  // Enforce tab width of 2 spaces.
-  "indent": 2,
+  // Require curly braces around blocks
+  "curly": true,
 
-  // Prohibit use of a variable before it is defined.
-  "latedef": true,
+  // Must explicitly check an object's items when looping with for ... in
+  "forin": true,
 
-  // Enforce line length to 80 characters
-  "maxlen": 80,
+  // Prohibit overwriting native prototype functions
+  "freeze": true,
 
-  // Require capitalized names for constructor functions.
-  "newcap": true,
+  // Prohibit use of a variable before it is defined.
+  "latedef": true,
 
-  // Enforce use of single quotation marks for strings.
-  "quotmark": "single",
+  // Prohibit use of arguments.caller, arguments.callee
+  "noarg": true,
 
   // Enforce placing 'use strict' at the top function scope
   "strict": true,

From 27c047caba08e25f332002aa6c7bb50af989e59d Mon Sep 17 00:00:00 2001
From: Stephen Thompson <scthompson@npr.org>
Date: Wed, 13 Dec 2017 11:44:39 -0500
Subject: [PATCH 07/13] Ignore IntelliJ IDE files

---
 .gitignore | 1 +
 1 file changed, 1 insertion(+)

diff --git a/.gitignore b/.gitignore
index ac10dfe528..ad7aa12883 100644
--- a/.gitignore
+++ b/.gitignore
@@ -1,6 +1,7 @@
 # gitignore
 
 node_modules
+.idea
 
 # Only apps should have lockfiles
 yarn.lock

From 742339fa35993bffdb255c54ddb55f4b27423fc9 Mon Sep 17 00:00:00 2001
From: Stephen Thompson <scthompson@npr.org>
Date: Wed, 13 Dec 2017 13:08:48 -0500
Subject: [PATCH 08/13] Create & publish esling-config-npr-base

---
 packages/eslint-config-npr-base/.babelrc      |  3 ++
 packages/eslint-config-npr-base/.editorconfig | 11 ++++
 packages/eslint-config-npr-base/.eslintrc     |  8 +++
 packages/eslint-config-npr-base/CHANGELOG.md  |  3 ++
 packages/eslint-config-npr-base/README.md     | 46 +++++++++++++++++
 packages/eslint-config-npr-base/index.js      | 17 +++++++
 packages/eslint-config-npr-base/package.json  | 50 +++++++++++++++++++
 .../eslint-config-npr-base/rules/general.js   | 28 +++++++++++
 .../eslint-config-npr-base/test/.eslintrc     |  8 +++
 .../eslint-config-npr-base/test/test-base.js  | 32 ++++++++++++
 10 files changed, 206 insertions(+)
 create mode 100644 packages/eslint-config-npr-base/.babelrc
 create mode 100644 packages/eslint-config-npr-base/.editorconfig
 create mode 100644 packages/eslint-config-npr-base/.eslintrc
 create mode 100644 packages/eslint-config-npr-base/CHANGELOG.md
 create mode 100644 packages/eslint-config-npr-base/README.md
 create mode 100644 packages/eslint-config-npr-base/index.js
 create mode 100644 packages/eslint-config-npr-base/package.json
 create mode 100644 packages/eslint-config-npr-base/rules/general.js
 create mode 100644 packages/eslint-config-npr-base/test/.eslintrc
 create mode 100644 packages/eslint-config-npr-base/test/test-base.js

diff --git a/packages/eslint-config-npr-base/.babelrc b/packages/eslint-config-npr-base/.babelrc
new file mode 100644
index 0000000000..e0aceaae1c
--- /dev/null
+++ b/packages/eslint-config-npr-base/.babelrc
@@ -0,0 +1,3 @@
+{
+  "presets": ["airbnb"]
+}
diff --git a/packages/eslint-config-npr-base/.editorconfig b/packages/eslint-config-npr-base/.editorconfig
new file mode 100644
index 0000000000..2895e4735d
--- /dev/null
+++ b/packages/eslint-config-npr-base/.editorconfig
@@ -0,0 +1,11 @@
+root = true
+
+[*]
+indent_style = space
+indent_size = 4
+charset = utf-8
+trim_trailing_whitespace = true
+insert_final_newline = true
+end_of_line = lf
+# editorconfig-tools is unable to ignore longs strings or urls
+max_line_length = null
diff --git a/packages/eslint-config-npr-base/.eslintrc b/packages/eslint-config-npr-base/.eslintrc
new file mode 100644
index 0000000000..224149fda6
--- /dev/null
+++ b/packages/eslint-config-npr-base/.eslintrc
@@ -0,0 +1,8 @@
+{
+  "extends": "./index.js",
+  "rules": {
+    // disable requiring trailing commas because it might be nice to revert to
+    // being JSON at some point, and I don't want to make big changes now.
+    "comma-dangle": 0
+  },
+}
diff --git a/packages/eslint-config-npr-base/CHANGELOG.md b/packages/eslint-config-npr-base/CHANGELOG.md
new file mode 100644
index 0000000000..2fda72332e
--- /dev/null
+++ b/packages/eslint-config-npr-base/CHANGELOG.md
@@ -0,0 +1,3 @@
+12.1.0 / 2017-12-13
+==================
+   - Initial commit; building off of `eslint-config-airbnb-base` package.
diff --git a/packages/eslint-config-npr-base/README.md b/packages/eslint-config-npr-base/README.md
new file mode 100644
index 0000000000..7317ef4c5d
--- /dev/null
+++ b/packages/eslint-config-npr-base/README.md
@@ -0,0 +1,46 @@
+# eslint-config-npr-base
+
+This package provides NPR's base JS .eslintrc (without React plugins) as an extensible shared config.
+
+It extends Airbnb's base configuration with NPR's style guide.
+
+## Usage
+
+Our default export contains all of our ESLint rules, including ECMAScript 6+. It requires `eslint` and `eslint-plugin-import`.
+
+If you use yarn, run `npm info "@npr/eslint-config-npr-base@latest" peerDependencies` to list the peer dependencies and versions, then run `yarn add --dev <dependency>@<version>` for each listed peer dependency. See below for npm instructions.
+
+1. Install the correct versions of each package, which are listed by the command:
+
+    ```sh
+    npm info "@npr/eslint-config-npr-base@latest" peerDependencies
+    ```
+
+    Linux/OSX users can run
+    ```sh
+    (
+    export PKG=@npr/eslint-config-npr-base;
+    npm info "$PKG@latest" peerDependencies --json | command sed 's/[\{\},]//g ; s/: /@/g' | xargs npm install --save-dev "$PKG@latest"
+    )
+    ```
+
+    Which produces and runs a command like:
+
+    ```sh
+    npm install --save-dev @npr/eslint-config-npr-base eslint@^#.#.# eslint-plugin-import@^#.#.#
+    ```
+
+    Windows users can either install all the peer dependencies manually, or use the [install-peerdeps](https://github.com/nathanhleung/install-peerdeps) cli tool.
+
+    ```sh
+    npm install -g install-peerdeps
+    install-peerdeps --dev @npr/eslint-config-npr-base
+    ```
+
+    The cli will produce and run a command like:
+
+    ```sh
+    npm install --save-dev @npr/eslint-config-npr-base eslint@^#.#.# eslint-plugin-import@^#.#.#
+    ```
+
+2. Add `"extends": "@npr/esling-config-npr-base"` to your .eslintrc.
diff --git a/packages/eslint-config-npr-base/index.js b/packages/eslint-config-npr-base/index.js
new file mode 100644
index 0000000000..9132bf19dd
--- /dev/null
+++ b/packages/eslint-config-npr-base/index.js
@@ -0,0 +1,17 @@
+module.exports = {
+    extends: [
+        'eslint-config-airbnb-base',
+        'eslint-config-airbnb-base/rules/strict',
+        './rules/general',
+    ].map(require.resolve),
+    parserOptions: {
+        ecmaVersion: 2017,
+        sourceType: 'module',
+        ecmaFeatures: {
+            experimentalObjectRestSpread: true,
+        },
+    },
+    rules: {
+        strict: 'error',
+    },
+};
diff --git a/packages/eslint-config-npr-base/package.json b/packages/eslint-config-npr-base/package.json
new file mode 100644
index 0000000000..003a3efa9f
--- /dev/null
+++ b/packages/eslint-config-npr-base/package.json
@@ -0,0 +1,50 @@
+{
+    "name": "@npr/eslint-config-npr-base",
+    "version": "12.1.0",
+    "description": "NPR's base style guide for JavaScript",
+    "main": "index.js",
+    "scripts": {
+        "prelint": "editorconfig-tools check * rules/* test/*",
+        "lint": "eslint --report-unused-disable-directives .",
+        "tests-only": "babel-tape-runner ./test/test-*.js",
+        "prepublish": "(in-install || eslint-find-rules --unused) && (not-in-publish || npm test)",
+        "pretest": "npm run --silent lint",
+        "test": "npm run --silent tests-only"
+    },
+    "repository": {
+        "type": "git",
+        "url": "git+https://github.com/npr/javascript.git"
+    },
+    "keywords": [
+        "javascript",
+        "style"
+    ],
+    "author": "Stephen Thompson <apostrophest@gmail.com>",
+    "license": "UNLICENSED",
+    "bugs": {
+        "url": "https://github.com/npr/javascript/issues"
+    },
+    "homepage": "https://github.com/npr/javascript#readme",
+    "devDependencies": {
+        "babel-preset-airbnb": "^2.4.0",
+        "babel-tape-runner": "^2.0.1",
+        "editorconfig-tools": "^0.1.1",
+        "eslint": "^4.9.0",
+        "eslint-find-rules": "^3.1.1",
+        "eslint-plugin-import": "^2.7.0",
+        "in-publish": "^2.0.0",
+        "safe-publish-latest": "^1.1.1",
+        "tape": "^4.8.0"
+    },
+    "peerDependencies": {
+        "eslint": "^4.9.0",
+        "eslint-plugin-import": "^2.7.0"
+    },
+    "engines": {
+        "node": ">= 6"
+    },
+    "dependencies": {
+        "eslint-config-airbnb-base": "^12.1.0",
+        "eslint-restricted-globals": "^0.1.1"
+    }
+}
diff --git a/packages/eslint-config-npr-base/rules/general.js b/packages/eslint-config-npr-base/rules/general.js
new file mode 100644
index 0000000000..cb600cc891
--- /dev/null
+++ b/packages/eslint-config-npr-base/rules/general.js
@@ -0,0 +1,28 @@
+module.exports = {
+    rules: {
+        indent: [
+            'error',
+            4,
+            { SwitchCase: 1 }
+        ],
+        'class-methods-use-this': 'off',
+        'space-before-function-paren': [
+            'error',
+            { anonymous: 'always', named: 'never', asyncArrow: 'always' }
+        ],
+        'comma-dangle': [
+            'error',
+            'always-multiline'
+        ],
+        'max-len': [
+            'warn',
+            {
+                code: 110,
+                ignoreComments: true,
+                ignoreUrls: true
+            }
+        ],
+        'implicit-arrow-linebreak': 'off',
+        'import/exports-last': 'off',
+    }
+};
diff --git a/packages/eslint-config-npr-base/test/.eslintrc b/packages/eslint-config-npr-base/test/.eslintrc
new file mode 100644
index 0000000000..5808be6186
--- /dev/null
+++ b/packages/eslint-config-npr-base/test/.eslintrc
@@ -0,0 +1,8 @@
+{
+  "rules": {
+    // disabled because I find it tedious to write tests while following this rule
+    "no-shadow": 0,
+    // tests uses `t` for tape
+    "id-length": [2, {"min": 2, "properties": "never", "exceptions": ["t"]}],
+  }
+}
diff --git a/packages/eslint-config-npr-base/test/test-base.js b/packages/eslint-config-npr-base/test/test-base.js
new file mode 100644
index 0000000000..aefbb5fe34
--- /dev/null
+++ b/packages/eslint-config-npr-base/test/test-base.js
@@ -0,0 +1,32 @@
+import fs from 'fs';
+import path from 'path';
+import test from 'tape';
+
+import index from '../';
+
+const files = { ...{ index } }; // object spread is to test parsing
+
+fs.readdirSync(path.join(__dirname, '../rules')).forEach((name) => {
+    // eslint-disable-next-line import/no-dynamic-require
+    files[name] = require(`../rules/${name}`); // eslint-disable-line global-require
+});
+
+Object.keys(files).forEach(( // eslint-disable-line function-paren-newline
+    name, // trailing function comma is to test parsing
+) => { // eslint-disable-line function-paren-newline
+    const config = files[name];
+
+    test(`${name}: does not reference react`, (t) => {
+        t.plan(2);
+
+        // scan plugins for react and fail if it is found
+        const hasReactPlugin = Object.prototype.hasOwnProperty.call(config, 'plugins') &&
+            config.plugins.indexOf('react') !== -1;
+        t.notOk(hasReactPlugin, 'there is no react plugin');
+
+        // scan rules for react/ and fail if any exist
+        const reactRuleIds = Object.keys(config.rules)
+            .filter(ruleId => ruleId.indexOf('react/') === 0);
+        t.deepEquals(reactRuleIds, [], 'there are no react/ rules');
+    });
+});

From cb7c3c2033f422517a42b9032e93a605368606f3 Mon Sep 17 00:00:00 2001
From: Stephen Thompson <scthompson@npr.org>
Date: Wed, 13 Dec 2017 13:55:36 -0500
Subject: [PATCH 09/13] Create & publish eslint-config-npr-react

---
 packages/eslint-config-npr-react/.babelrc     |  3 ++
 .../eslint-config-npr-react/.editorconfig     | 11 +++++
 packages/eslint-config-npr-react/.eslintrc    |  8 +++
 packages/eslint-config-npr-react/CHANGELOG.md |  3 ++
 packages/eslint-config-npr-react/README.md    | 49 +++++++++++++++++++
 packages/eslint-config-npr-react/index.js     |  8 +++
 packages/eslint-config-npr-react/package.json | 46 +++++++++++++++++
 .../eslint-config-npr-react/rules/react.js    | 11 +++++
 .../eslint-config-npr-react/test/.eslintrc    |  8 +++
 .../eslint-config-npr-react/test/test-base.js |  0
 10 files changed, 147 insertions(+)
 create mode 100644 packages/eslint-config-npr-react/.babelrc
 create mode 100644 packages/eslint-config-npr-react/.editorconfig
 create mode 100644 packages/eslint-config-npr-react/.eslintrc
 create mode 100644 packages/eslint-config-npr-react/CHANGELOG.md
 create mode 100644 packages/eslint-config-npr-react/README.md
 create mode 100644 packages/eslint-config-npr-react/index.js
 create mode 100644 packages/eslint-config-npr-react/package.json
 create mode 100644 packages/eslint-config-npr-react/rules/react.js
 create mode 100644 packages/eslint-config-npr-react/test/.eslintrc
 create mode 100644 packages/eslint-config-npr-react/test/test-base.js

diff --git a/packages/eslint-config-npr-react/.babelrc b/packages/eslint-config-npr-react/.babelrc
new file mode 100644
index 0000000000..e0aceaae1c
--- /dev/null
+++ b/packages/eslint-config-npr-react/.babelrc
@@ -0,0 +1,3 @@
+{
+  "presets": ["airbnb"]
+}
diff --git a/packages/eslint-config-npr-react/.editorconfig b/packages/eslint-config-npr-react/.editorconfig
new file mode 100644
index 0000000000..2895e4735d
--- /dev/null
+++ b/packages/eslint-config-npr-react/.editorconfig
@@ -0,0 +1,11 @@
+root = true
+
+[*]
+indent_style = space
+indent_size = 4
+charset = utf-8
+trim_trailing_whitespace = true
+insert_final_newline = true
+end_of_line = lf
+# editorconfig-tools is unable to ignore longs strings or urls
+max_line_length = null
diff --git a/packages/eslint-config-npr-react/.eslintrc b/packages/eslint-config-npr-react/.eslintrc
new file mode 100644
index 0000000000..224149fda6
--- /dev/null
+++ b/packages/eslint-config-npr-react/.eslintrc
@@ -0,0 +1,8 @@
+{
+  "extends": "./index.js",
+  "rules": {
+    // disable requiring trailing commas because it might be nice to revert to
+    // being JSON at some point, and I don't want to make big changes now.
+    "comma-dangle": 0
+  },
+}
diff --git a/packages/eslint-config-npr-react/CHANGELOG.md b/packages/eslint-config-npr-react/CHANGELOG.md
new file mode 100644
index 0000000000..a3458a5035
--- /dev/null
+++ b/packages/eslint-config-npr-react/CHANGELOG.md
@@ -0,0 +1,3 @@
+16.1.0 / 2017-12-13
+==================
+   - Initial commit; building off of `eslint-config-airbnb` package.
diff --git a/packages/eslint-config-npr-react/README.md b/packages/eslint-config-npr-react/README.md
new file mode 100644
index 0000000000..7b250bfc60
--- /dev/null
+++ b/packages/eslint-config-npr-react/README.md
@@ -0,0 +1,49 @@
+# eslint-config-npr-react
+
+This package provides NPR's JS .eslintrc with React plugins as an extensible shared config.
+
+It extends Airbnb's full configuration with NPR's style guide.
+
+## Usage
+
+Our default export contains all of our ESLint rules, including ECMAScript 6+.
+
+It requires `eslint`, `eslint-plugin-import`, `eslint-plugin-react`, and `eslint-plugin-jsx-a11y`. If you don't need React, see [eslint-config-npr-base](https://www.npmjs.com/package/@npr/eslint-config-npr-base).
+
+If you use yarn, run `npm info "@npr/eslint-config-npr-react@latest" peerDependencies` to list the peer dependencies and versions, then run `yarn add --dev <dependency>@<version>` for each listed peer dependency. See below for npm instructions.
+
+1. Install the correct versions of each package, which are listed by the command:
+
+    ```sh
+    npm info "@npr/eslint-config-npr-react@latest" peerDependencies
+    ```
+
+    Linux/OSX users can run
+
+    ```sh
+    (
+    export PKG=@npr/eslint-config-npr-react;
+    npm info "$PKG@latest" peerDependencies --json | command sed 's/[\{\},]//g ; s/: /@/g' | xargs npm install --save-dev "$PKG@latest"
+    )
+    ```
+
+    Which produces and runs a command like:
+
+    ```sh
+    npm install --save-dev @npr/eslint-config-npr-react eslint@^#.#.# eslint-plugin-jsx-a11y@^#.#.# eslint-plugin-import@^#.#.# eslint-plugin-react@^#.#.#
+    ```
+
+    Windows users can either install all the peer dependencies manually, or use the [install-peerdeps](https://github.com/nathanhleung/install-peerdeps) cli tool.
+
+    ```sh
+    npm install -g install-peerdeps
+    install-peerdeps --dev @npr/eslint-config-npr-react
+    ```
+
+    The cli will produce and run a command like:
+
+    ```sh
+    npm install --save-dev @npr/eslint-config-npr-react eslint@^#.#.# eslint-plugin-jsx-a11y@^#.#.# eslint-plugin-import@^#.#.# eslint-plugin-react@^#.#.#
+    ```
+
+2. Add `"extends": "@npr/esling-config-npr-react"` to your .eslintrc
diff --git a/packages/eslint-config-npr-react/index.js b/packages/eslint-config-npr-react/index.js
new file mode 100644
index 0000000000..14e4304ae5
--- /dev/null
+++ b/packages/eslint-config-npr-react/index.js
@@ -0,0 +1,8 @@
+module.exports = {
+    extends: [
+        'eslint-config-airbnb',
+        '@npr/eslint-config-npr-base',
+        './rules/react',
+    ].map(require.resolve),
+    rules: {},
+};
diff --git a/packages/eslint-config-npr-react/package.json b/packages/eslint-config-npr-react/package.json
new file mode 100644
index 0000000000..2ffb726ed0
--- /dev/null
+++ b/packages/eslint-config-npr-react/package.json
@@ -0,0 +1,46 @@
+{
+    "name": "@npr/eslint-config-npr-react",
+    "version": "16.1.0",
+    "description": "NPR's React style guide for JavaScript",
+    "main": "index.js",
+    "scripts": {
+        "prelint": "editorconfig-tools check * rules/* test/*",
+        "lint": "eslint --report-unused-disable-directives .",
+        "tests-only": "babel-tape-runner ./test/test-*.js",
+        "prepublish": "(in-install || eslint-find-rules --unused) && (not-in-publish || npm test)",
+        "pretest": "npm run --silent lint",
+        "test": "npm run --silent tests-only"
+    },
+    "repository": {
+        "type": "git",
+        "url": "git+https://github.com/npr/javascript.git"
+    },
+    "keywords": [
+        "javascript",
+        "style"
+    ],
+    "author": "Stephen Thompson <apostrophest@gmail.com>",
+    "license": "UNLICENSED",
+    "bugs": {
+        "url": "https://github.com/npr/javascript/issues"
+    },
+    "homepage": "https://github.com/npr/javascript#readme",
+    "devDependencies": {
+        "babel-preset-airbnb": "^2.4.0",
+        "babel-tape-runner": "^2.0.1",
+        "editorconfig-tools": "^0.1.1",
+        "eslint": "^4.9.0",
+        "eslint-find-rules": "^3.1.1",
+        "eslint-plugin-import": "^2.7.0",
+        "in-publish": "^2.0.0",
+        "safe-publish-latest": "^1.1.1",
+        "tape": "^4.8.0"
+    },
+    "engines": {
+        "node": ">= 6"
+    },
+    "dependencies": {
+        "@npr/eslint-config-npr-base": "^12.1.0",
+        "eslint-config-airbnb": "^16.1.0"
+    }
+}
diff --git a/packages/eslint-config-npr-react/rules/react.js b/packages/eslint-config-npr-react/rules/react.js
new file mode 100644
index 0000000000..460629a976
--- /dev/null
+++ b/packages/eslint-config-npr-react/rules/react.js
@@ -0,0 +1,11 @@
+module.exports = {
+    rules: {
+        'react/jsx-indent-props': ['error', 4],
+        'react/jsx-indent': ['error', 4],
+        'react/jsx-filename-extension': 'off',
+        'react/button-has-type': 'warn',
+        'react/destructuring-assignment': 'off',
+        'react/jsx-one-expression-per-line': 'error',
+        'react/no-access-state-in-setstate': 'warn',
+    }
+};
diff --git a/packages/eslint-config-npr-react/test/.eslintrc b/packages/eslint-config-npr-react/test/.eslintrc
new file mode 100644
index 0000000000..5808be6186
--- /dev/null
+++ b/packages/eslint-config-npr-react/test/.eslintrc
@@ -0,0 +1,8 @@
+{
+  "rules": {
+    // disabled because I find it tedious to write tests while following this rule
+    "no-shadow": 0,
+    // tests uses `t` for tape
+    "id-length": [2, {"min": 2, "properties": "never", "exceptions": ["t"]}],
+  }
+}
diff --git a/packages/eslint-config-npr-react/test/test-base.js b/packages/eslint-config-npr-react/test/test-base.js
new file mode 100644
index 0000000000..e69de29bb2

From f77ed06fc31284780eed0d340810599fcdd9d5ce Mon Sep 17 00:00:00 2001
From: Stephen Thompson <scthompson@npr.org>
Date: Thu, 14 Dec 2017 11:14:52 -0500
Subject: [PATCH 10/13] 16.1.1

---
 packages/eslint-config-npr-react/package.json   | 2 +-
 packages/eslint-config-npr-react/rules/react.js | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/packages/eslint-config-npr-react/package.json b/packages/eslint-config-npr-react/package.json
index 2ffb726ed0..5dbec25b4b 100644
--- a/packages/eslint-config-npr-react/package.json
+++ b/packages/eslint-config-npr-react/package.json
@@ -1,6 +1,6 @@
 {
     "name": "@npr/eslint-config-npr-react",
-    "version": "16.1.0",
+    "version": "16.1.1",
     "description": "NPR's React style guide for JavaScript",
     "main": "index.js",
     "scripts": {
diff --git a/packages/eslint-config-npr-react/rules/react.js b/packages/eslint-config-npr-react/rules/react.js
index 460629a976..178a922680 100644
--- a/packages/eslint-config-npr-react/rules/react.js
+++ b/packages/eslint-config-npr-react/rules/react.js
@@ -5,7 +5,7 @@ module.exports = {
         'react/jsx-filename-extension': 'off',
         'react/button-has-type': 'warn',
         'react/destructuring-assignment': 'off',
-        'react/jsx-one-expression-per-line': 'error',
+        'react/jsx-one-expression-per-line': 'off',
         'react/no-access-state-in-setstate': 'warn',
     }
 };

From c04cfd31d53e88bea15251f2d666fbc9faa5fc76 Mon Sep 17 00:00:00 2001
From: Stephen Thompson <scthompson@npr.org>
Date: Thu, 14 Dec 2017 14:33:10 -0500
Subject: [PATCH 11/13] Comment react rule decisions, turn off
 jsx-a11y/label-has-for

---
 packages/eslint-config-npr-react/rules/react.js | 15 ++++++++++++++-
 1 file changed, 14 insertions(+), 1 deletion(-)

diff --git a/packages/eslint-config-npr-react/rules/react.js b/packages/eslint-config-npr-react/rules/react.js
index 178a922680..300c1d1f22 100644
--- a/packages/eslint-config-npr-react/rules/react.js
+++ b/packages/eslint-config-npr-react/rules/react.js
@@ -1,11 +1,24 @@
 module.exports = {
     rules: {
+        // Use our 4-space indent rules for JSX as well
         'react/jsx-indent-props': ['error', 4],
         'react/jsx-indent': ['error', 4],
+        // We may want to require .jsx extension for files with JSX in the future
         'react/jsx-filename-extension': 'off',
+        // We should probably bump this up to error soon
         'react/button-has-type': 'warn',
+        // We are not requiring that functional components destructure their props
+        // right now, but we can reevaluate in the future
         'react/destructuring-assignment': 'off',
+        // I would love to have this turned on, but it is a little oversensitive.
+        // The following line is considered a violation even though the documentation
+        // does not even seem to be aware of a case like this:
+        // <h1>Here is the title</h1>
+        // That seems to pretty clearly be one JSX expression on one line...
         'react/jsx-one-expression-per-line': 'off',
-        'react/no-access-state-in-setstate': 'warn',
+        // I'd really like to have this on, but the parser seems to flag cases even when
+        // there is a clear htmlFor on a label that matches up with the ID of another
+        // element. Turn this on when it parses better.
+        'jsx-a11y/label-has-for': 'off',
     }
 };

From f9129988009300a97596e621f80a0fc60e6691f0 Mon Sep 17 00:00:00 2001
From: Stephen Thompson <scthompson@npr.org>
Date: Thu, 14 Dec 2017 14:35:38 -0500
Subject: [PATCH 12/13] 16.1.2

---
 packages/eslint-config-npr-react/package.json   | 2 +-
 packages/eslint-config-npr-react/rules/react.js | 2 ++
 2 files changed, 3 insertions(+), 1 deletion(-)

diff --git a/packages/eslint-config-npr-react/package.json b/packages/eslint-config-npr-react/package.json
index 5dbec25b4b..2f17b8cc67 100644
--- a/packages/eslint-config-npr-react/package.json
+++ b/packages/eslint-config-npr-react/package.json
@@ -1,6 +1,6 @@
 {
     "name": "@npr/eslint-config-npr-react",
-    "version": "16.1.1",
+    "version": "16.1.2",
     "description": "NPR's React style guide for JavaScript",
     "main": "index.js",
     "scripts": {
diff --git a/packages/eslint-config-npr-react/rules/react.js b/packages/eslint-config-npr-react/rules/react.js
index 300c1d1f22..48723be83a 100644
--- a/packages/eslint-config-npr-react/rules/react.js
+++ b/packages/eslint-config-npr-react/rules/react.js
@@ -16,6 +16,8 @@ module.exports = {
         // <h1>Here is the title</h1>
         // That seems to pretty clearly be one JSX expression on one line...
         'react/jsx-one-expression-per-line': 'off',
+        // This should be an error because violations can actually lead to bugs.
+        'react/no-access-state-in-setstate': 'error',
         // I'd really like to have this on, but the parser seems to flag cases even when
         // there is a clear htmlFor on a label that matches up with the ID of another
         // element. Turn this on when it parses better.

From a801a5fa73d906f41e134f125a8437f8558a8e1e Mon Sep 17 00:00:00 2001
From: mdoumit-npr <mdoumit@npr.org>
Date: Tue, 23 Jan 2018 14:08:07 -0500
Subject: [PATCH 13/13] Fix typo

---
 packages/eslint-config-npr-base/README.md | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/packages/eslint-config-npr-base/README.md b/packages/eslint-config-npr-base/README.md
index 7317ef4c5d..5cb653944d 100644
--- a/packages/eslint-config-npr-base/README.md
+++ b/packages/eslint-config-npr-base/README.md
@@ -43,4 +43,4 @@ If you use yarn, run `npm info "@npr/eslint-config-npr-base@latest" peerDependen
     npm install --save-dev @npr/eslint-config-npr-base eslint@^#.#.# eslint-plugin-import@^#.#.#
     ```
 
-2. Add `"extends": "@npr/esling-config-npr-base"` to your .eslintrc.
+2. Add `"extends": "@npr/eslint-config-npr-base"` to your .eslintrc.