feat: drop mirror signal in favor of linked signal (#493)

Harpush · web-flow · commit b21f71d8703d · 2025-02-02T21:21:02.000+01:00
diff --git a/projects/angular-split/src/lib/split-area/split-area.component.ts b/projects/angular-split/src/lib/split-area/split-area.component.ts
@@ -8,9 +8,10 @@ import {
   inject,
   input,
   isDevMode,
+  linkedSignal,
 } from '@angular/core'
 import { SPLIT_AREA_CONTRACT, SplitComponent } from '../split/split.component'
-import { createClassesString, mirrorSignal } from '../utils'
+import { createClassesString } from '../utils'
 import { SplitAreaSize, areaSizeTransform, boundaryAreaSizeTransform } from '../models'
 
 @Component({
@@ -39,19 +40,15 @@ export class SplitAreaComponent {
   /**
    * @internal
    */
-  readonly _internalSize = mirrorSignal(
-    // As size is an input and we can change the size without the outside
-    // listening to the change we need an intermediate writeable signal
-    computed((): SplitAreaSize => {
-      if (!this.visible()) {
-        return 0
-      }
+  readonly _internalSize = linkedSignal((): SplitAreaSize => {
+    if (!this.visible()) {
+      return 0
+    }
 
-      const visibleIndex = this.split._visibleAreas().findIndex((area) => area === this)
+    const visibleIndex = this.split._visibleAreas().findIndex((area) => area === this)
 
-      return this.split._alignedVisibleAreasSizes()[visibleIndex]
-    }),
-  )
+    return this.split._alignedVisibleAreasSizes()[visibleIndex]
+  })
   /**
    * @internal
    */
diff --git a/projects/angular-split/src/lib/utils.ts b/projects/angular-split/src/lib/utils.ts
@@ -1,4 +1,4 @@
-import { NgZone, Signal, computed, inject, numberAttribute, signal, untracked } from '@angular/core'
+import { NgZone, inject, numberAttribute } from '@angular/core'
 import { Observable, filter, fromEvent, merge } from 'rxjs'
 
 export interface ClientPoint {
@@ -106,25 +106,6 @@ export function createClassesString(classesRecord: Record<string, boolean>) {
     .join(' ')
 }
 
-export interface MirrorSignal<T> {
-  (): T
-  set(value: T): void
-  reset(): void
-}
-
-/**
- * Creates a semi signal which allows writes but is based on an existing signal
- * Whenever the original signal changes the mirror signal gets aligned
- * overriding the current value inside.
- */
-export function mirrorSignal<T>(outer: Signal<T>): MirrorSignal<T> {
-  const inner = computed(() => signal(outer()))
-  const mirror: MirrorSignal<T> = () => inner()()
-  mirror.set = (value: T) => untracked(inner).set(value)
-  mirror.reset = () => untracked(() => inner().set(outer()))
-  return mirror
-}
-
 export function leaveNgZone<T>() {
   return (source: Observable<T>) =>
     new Observable<T>((observer) => inject(NgZone).runOutsideAngular(() => source.subscribe(observer)))
