Skip to content

Conversation

@dxbrandon
Copy link
Contributor

@dxbrandon dxbrandon commented Jan 21, 2022

Bringing back an old pull request from Michelle to add keyboard accessibility: #269.

From Michelle's PR:

  • Added "startKeyboardDrag", which uses new util functions to calculate the start and end points differently from mouse events.
  • Moved chunks of "startMouseDrag" out into separate functions so that keyboard drag can share the code: this.startDragging(), this.drag();, this.stopDragging();
  • Consumers are able to optionally add a text for aria-label via @input().

Additional features:

  • Added role="slider" and made the dragger/gutter tab-able.
  • Added aria-orientation, aria-valuemin, aria-valuemax, aria-valuenow, aria-valuetext.
  • Added PageUp and PageDown support. Arrow keys does a step offset of 50. PageUp and PageDown does a step offset of 500.
  • Added util functions to help test keyboard functionality in the e2e tests. Changed "moveGutter" into "moveGutterByMouse" and introduced "moveGutterByKeyboard", "checkGutterAriaLabel", "checkGuttersAriaValueTexts"

Issues discovered while developing:

  • Tab order of the gutters is not top-down left-right
  • In screenreader mode, displayed areas with a size of "*" are not supported because size is null in the displayed area.

Keyboard support:
keyboard-support

Screen reader:
screen-reader

@beeman beeman merged commit 5b45039 into angular-split:main Feb 13, 2022
@beeman
Copy link
Collaborator

beeman commented Feb 13, 2022

Thanks for your contribution @dxbrandon! This is now released as version 13.2.0!

@bBaxta
Copy link

bBaxta commented Mar 17, 2022

Will the identified issues found during development be fixed in an up coming release? Specifically "Tab order of the gutters is not top-down left-right".

Thanks!

@beeman
Copy link
Collaborator

beeman commented Mar 17, 2022

@bBaxta please create a new issue with a reproduction if you have any issues.

Commenting on closed PR's is not a great way to track things ;-)

@angular-split angular-split locked as resolved and limited conversation to collaborators Mar 17, 2022
@Jefiozie
Copy link
Member

@all-contributors please add @dxbrandon for code.

🤖 Beep boop! This comment was added automatically by all-contributors-auto-action.
Not all contributions can be detected from Git & GitHub alone. Please comment any missing contribution types this bot missed.
...and of course, thank you for contributing! 💙

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants