Skip to content

New config key "allow.import.volume.with.backing.file" to skip volume backing#12809

Open
sudo87 wants to merge 3 commits intoapache:4.22from
shapeblue:skip-volume-backing
Open

New config key "allow.import.volume.with.backing.file" to skip volume backing#12809
sudo87 wants to merge 3 commits intoapache:4.22from
shapeblue:skip-volume-backing

Conversation

@sudo87
Copy link
Contributor

@sudo87 sudo87 commented Mar 13, 2026

Description

This PR introduces a new configkey "allow.import.volume.with.backing.file" with default value: false to skip volume backing.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • Build/CI
  • Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

rajujith and others added 2 commits March 13, 2026 10:05
…lumes and VMs. This allows users to import volumes and VMs without creating a backing volume, which can be useful in certain scenarios where the backing volume is not needed or desired.
@sudo87
Copy link
Contributor Author

sudo87 commented Mar 13, 2026

@blueorangutan package

@blueorangutan
Copy link

@sudo87 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@codecov
Copy link

codecov bot commented Mar 13, 2026

Codecov Report

❌ Patch coverage is 11.11111% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 17.60%. Comparing base (5caf6cd) to head (a9c3332).
⚠️ Report is 22 commits behind head on 4.22.

Files with missing lines Patch % Lines
...torage/volume/VolumeImportUnmanageManagerImpl.java 0.00% 6 Missing and 1 partial ⚠️
.../apache/cloudstack/vm/UnmanagedVMsManagerImpl.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               4.22   #12809      +/-   ##
============================================
- Coverage     17.60%   17.60%   -0.01%     
+ Complexity    15659    15657       -2     
============================================
  Files          5917     5917              
  Lines        531394   531422      +28     
  Branches      64970    64973       +3     
============================================
+ Hits          93575    93576       +1     
- Misses       427269   427289      +20     
- Partials      10550    10557       +7     
Flag Coverage Δ
uitests 3.70% <ø> (-0.01%) ⬇️
unittests 18.68% <11.11%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 17128

Copy link

@rajujith rajujith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Tested.

Copy link
Member

@weizhouapache weizhouapache left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm

@sureshanaparti sureshanaparti added this to the 4.22.1 milestone Mar 13, 2026
@sudo87 sudo87 marked this pull request as ready for review March 13, 2026 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: In Progress

Development

Successfully merging this pull request may close these issues.

5 participants