feat: adds wrangler version check

dom96 · dom96 · commit ed41bccf24d5 · 2025-10-10T10:53:27.000+01:00
diff --git a/src/pywrangler/cli.py b/src/pywrangler/cli.py
@@ -57,6 +57,11 @@ def get_command(self, ctx, cmd_name):
             if cmd_name in ["dev", "publish", "deploy", "versions"]:
                 ctx.invoke(sync_command, force=False, directly_requested=False)
 
+            if cmd_name == "dev":
+                from pywrangler.sync import check_wrangler_version
+
+                check_wrangler_version()
+
             _proxy_to_wrangler(cmd_name, remaining_args)
             sys.exit(0)
 
diff --git a/src/pywrangler/sync.py b/src/pywrangler/sync.py
@@ -1,5 +1,6 @@
 import logging
 import os
+import re
 import shutil
 import tempfile
 from contextlib import contextmanager
@@ -229,6 +230,7 @@ def create_workers_venv():
 
 
 MIN_UV_VERSION = (0, 8, 10)
+MIN_WRANGLER_VERSION = (4, 42, 1)
 
 
 def check_uv_version():
@@ -243,6 +245,48 @@ def check_uv_version():
     raise click.exceptions.Exit(code=1)
 
 
+def check_wrangler_version():
+    """
+    Check that the installed wrangler version is at least 4.42.1.
+
+    Raises:
+        click.exceptions.Exit: If wrangler is not installed or version is too old.
+    """
+    result = run_command(
+        ["npx", "--yes", "wrangler", "--version"], capture_output=True, check=False
+    )
+    if result.returncode != 0:
+        logger.error("Failed to get wrangler version. Is wrangler installed?")
+        logger.error("Install wrangler with: npm install wrangler@latest")
+        raise click.exceptions.Exit(code=1)
+
+    # Parse version from output like "wrangler 4.42.1" or " &#9925;&#65039; wrangler 4.42.1"
+    version_line = result.stdout.strip()
+    # Extract version number using regex
+    version_match = re.search(r"wrangler\s+(\d+)\.(\d+)\.(\d+)", version_line)
+
+    if not version_match:
+        logger.error(f"Could not parse wrangler version from: {version_line}")
+        logger.error("Install wrangler with: npm install wrangler@latest")
+        raise click.exceptions.Exit(code=1)
+
+    major, minor, patch = map(int, version_match.groups())
+    current_version = (major, minor, patch)
+
+    if current_version < MIN_WRANGLER_VERSION:
+        min_version_str = ".".join(str(x) for x in MIN_WRANGLER_VERSION)
+        current_version_str = ".".join(str(x) for x in current_version)
+        logger.error(
+            f"wrangler version at least {min_version_str} required, have {current_version_str}."
+        )
+        logger.error("Update wrangler with: npm install wrangler@latest")
+        raise click.exceptions.Exit(code=1)
+
+    logger.debug(
+        f"wrangler version {'.'.join(str(x) for x in current_version)} is sufficient"
+    )
+
+
 def create_pyodide_venv():
     if PYODIDE_VENV_PATH.is_dir():
         logger.debug(
diff --git a/tests/test_cli.py b/tests/test_cli.py
@@ -3,7 +3,7 @@
 import shutil
 import subprocess
 from pathlib import Path
-from unittest.mock import patch
+from unittest.mock import patch, Mock
 from textwrap import dedent
 
 import pytest
@@ -406,10 +406,13 @@ def test_proxy_to_wrangler_unknown_command(mock_proxy_to_wrangler):
     )
 
 
+@patch("pywrangler.sync.check_wrangler_version")
 @patch("pywrangler.cli._proxy_to_wrangler")
 @patch("pywrangler.cli.sync_command")
 @patch("sys.argv", ["pywrangler", "dev", "--local"])
-def test_proxy_auto_sync_commands(mock_sync_command, mock_proxy_to_wrangler):
+def test_proxy_auto_sync_commands(
+    mock_sync_command, mock_proxy_to_wrangler, mock_check_wrangler_version
+):
     """Test that dev, publish, and deploy commands automatically run sync first."""
     runner = CliRunner()
 
@@ -530,3 +533,42 @@ def test_sync_recreates_venv_on_python_version_mismatch(clean_test_dir):
     assert "3.13" in version_result.stdout, (
         f"Python version is not 3.13: {version_result.stdout}"
     )
+
+
+# Wrangler version check tests
+@patch("pywrangler.sync.run_command")
+def test_check_wrangler_version_sufficient(mock_run_command):
+    """Test that check_wrangler_version passes with sufficient version."""
+    from pywrangler.sync import check_wrangler_version
+
+    # Mock successful wrangler version output
+    mock_result = Mock()
+    mock_result.returncode = 0
+    mock_result.stdout = "wrangler 4.42.1"
+    mock_run_command.return_value = mock_result
+
+    # Should not raise an exception
+    check_wrangler_version()
+
+    # Verify the command was called correctly
+    mock_run_command.assert_called_once_with(
+        ["npx", "--yes", "wrangler", "--version"], capture_output=True, check=False
+    )
+
+
+@patch("pywrangler.sync.run_command")
+def test_check_wrangler_version_insufficient(mock_run_command):
+    """Test that check_wrangler_version fails with insufficient version."""
+    from pywrangler.sync import check_wrangler_version
+
+    # Mock wrangler version output with old version
+    mock_result = Mock()
+    mock_result.returncode = 0
+    mock_result.stdout = "&#9925;&#65039; wrangler 4.40.0"
+    mock_run_command.return_value = mock_result
+
+    # Should raise SystemExit
+    import click
+
+    with pytest.raises(click.exceptions.Exit):
+        check_wrangler_version()
