Skip to content

bug: JSONFlattener incorrectly handles casing for Tls #20192

@bbernays

Description

@bbernays

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

Currently because we normalize between cases snake and pascal, we turn minimumTlsVersion --> minimum_tls_version --> minimumTLSVersion

This means that when we are updating records the value for that column is always nil because the name doesn't match

Expected Behavior

We should never drop values

CloudQuery (redacted) config

kind: source
spec:
  name: "azure-tls"
  path: "cloudquery/azure"
  registry: "cloudquery"
  version: "v17.1.2"
  destinations: ["postgresql"]
  tables: [
    # "azure_appservice_web_app_configurations",
    # "azure_cosmos_database_accounts",
    # "azure_eventhub_namespaces",
    # "azure_hdinsight_clusters",
    # "azure_mariadb_servers",
    # "azure_mysql_servers",
    # "azure_postgresql_servers",
    # "azure_redis_caches",
    # "azure_sql_managed_instances",
    # "azure_sql_servers",
    "azure_storage_accounts"
]
  spec:
    concurrency: 500

---
kind: transformer
spec:
  name: "jsonflattener"
  path: "cloudquery/jsonflattener"
  # registry: "grpc"
  # path: "localhost:7777"
  version: v2.0.2
  spec:
    tables: ["*"]

---
kind: destination
spec:
  name: "postgresql"
  path: "cloudquery/postgresql"
  registry: "cloudquery"
  version: "v8.7.8"
  migrate_mode: "forced"
  spec:
    connection_string: "postgresql://postgres:pass@localhost:5432/postgres?sslmode=disable"
  transformers:
    - "jsonflattener"

Steps To Reproduce

No response

CloudQuery (redacted) logs

NA

CloudQuery version

all

Additional Context

No response

Pull request (optional)

  • I can submit a pull request

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions