Custom filter refresh in management view#970
Merged
schabdo merged 2 commits intoeclipse-hawkbit:masterfrom Jun 18, 2020
Merged
Conversation
Add, modify and remove events handled for custom filter and the management page is updated acordingly Signed-off-by: Ajay Balakumar Jeyabalakrishnan <ajaybalakumar.jeyabalakrishnan@in.bosch.com>
|
Thanks for taking the time to contribute to hawkBit! We really appreciate this. Make yourself comfortable while I'm looking for a committer to help you with your contribution. |
Contributor
|
Thanks for tackling this bug, highly appreciated! @bogdan-bondar may I asked you to have a look at the PR and provide feedback? |
bogdan-bondar
requested changes
Jun 5, 2020
...c/main/java/org/eclipse/hawkbit/ui/management/targettag/filter/TargetFilterQueryButtons.java
Outdated
Show resolved
Hide resolved
hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/management/targettable/TargetTable.java
Outdated
Show resolved
Hide resolved
hawkbit-bot
reviewed
Jun 10, 2020
hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/management/targettable/TargetTable.java
Outdated
Show resolved
Hide resolved
hawkbit-bot
reviewed
Jun 10, 2020
hawkbit-ui/src/main/java/org/eclipse/hawkbit/ui/management/targettable/TargetTable.java
Outdated
Show resolved
Hide resolved
hawkbit-bot
reviewed
Jun 10, 2020
...c/main/java/org/eclipse/hawkbit/ui/management/targettag/filter/TargetFilterQueryButtons.java
Show resolved
Hide resolved
hawkbit-bot
reviewed
Jun 10, 2020
...c/main/java/org/eclipse/hawkbit/ui/management/targettag/filter/TargetFilterQueryButtons.java
Show resolved
Hide resolved
|
SonarQube analysis reported 4 issues
Watch the comments in this conversation to review them. |
Review comments fixed. Signed-off-by: Ajay Balakumar Jeyabalakrishnan <ajaybalakumar.jeyabalakrishnan@in.bosch.com>
AmmarBikic
pushed a commit
to bosch-io/hawkbit
that referenced
this pull request
Oct 2, 2020
…ipse-hawkbit#970) * Custom Filter refreshed in management page Add, modify and remove events handled for custom filter and the management page is updated acordingly Signed-off-by: Ajay Balakumar Jeyabalakrishnan <ajaybalakumar.jeyabalakrishnan@in.bosch.com> * Custom Filter refreshed in management page - eclipse-hawkbit#916 Review comments fixed. Signed-off-by: Ajay Balakumar Jeyabalakrishnan <ajaybalakumar.jeyabalakrishnan@in.bosch.com>
krishna-devolo
pushed a commit
to devolo/hawkbit
that referenced
this pull request
Sep 23, 2021
…ipse-hawkbit#970) * Custom Filter refreshed in management page Add, modify and remove events handled for custom filter and the management page is updated acordingly Signed-off-by: Ajay Balakumar Jeyabalakrishnan <ajaybalakumar.jeyabalakrishnan@in.bosch.com> * Custom Filter refreshed in management page - eclipse-hawkbit#916 Review comments fixed. Signed-off-by: Ajay Balakumar Jeyabalakrishnan <ajaybalakumar.jeyabalakrishnan@in.bosch.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add, modify and remove events handled for custom filter and the
management page is updated accordingly
#916
Signed-off-by: Ajay Balakumar Jeyabalakrishnan ajaybalakumar.jeyabalakrishnan@in.bosch.com