-
Notifications
You must be signed in to change notification settings - Fork 109
Description
-
Move the test figures from app/addon to a dedicated addon for testing. Be sure to remove the treeFor hook after doing so.
-
Should coverage for addons be testing the % coverage of the dummy app or of the addon itself? I would think the later. (But not sure if this ever behaved this way).
-
I think we might want to bring back the try/catch around the require here https://github.com/kategengler/ember-cli-code-coverage/pull/145/files#diff-94eab975fb48e219fc130d82e21457acR6 so that if it does happen, we don't break anything. It was put in place because apparently people have some unused files in their apps that never get used and may be completely broken. Is this test https://github.com/kategengler/ember-cli-code-coverage/blob/master/tests/unit/handle-modules-throwing-on-import-test.js still testing the desired behavior? This has been handled in Add back "Avoid throwing errors while requiring files for coverage" #64 #153
TODO
- Manually test coverage-merge
- Manually test that files that are not required contribute to coverage % (a completely not tested or even used file lowers coverage %)
- Manually test that Addon files do not contribute to coverage % of app
- Manually test out using .istanbul.yml for configuration. Do we support all options? What if they conflict with our config? (If we don't support this for 1.0 it can be put off)
- Audit README for correctness
- Upgrade ember-cli to latest stable