Skip to content

No clear documentation on usage of beta version in actual ember addons #347

@robinborst95

Description

@robinborst95

Unlike the in-repo addons we have in our main repository, we also have actual addons with files in addon and app. When using the beta version, all app files are still covered, but the addon files aren't anymore. I've tried to resolve this with modifyAssetLocation (we don't need the --path option in the actual addons), but all relativePaths contained dummy (corresponding to app). So, it seems like the coverage is not only not reported, it's also not calculated at all anymore.

I was quite surprised that this wasn't covered by the tests, as I do see my-addon in the test-packages. However, that repo isn't used in any test, and I couldn't get a simple test working, so I guess that would need some more investigation.

The Readme does mention how to setup instrumentation in in-repo addons, but it doesn't mention that this same setup also applies to actual/standalone addons. In such addons that have app files (like our addon does) there is no setup example as well . It can be inferred from the other examples, but having it mentioned explicitly definitely helps with the setup.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions