From 2d11687ce625400e7165cf58b7a63f04e6c25b8e Mon Sep 17 00:00:00 2001 From: "Anand M.S" Date: Fri, 15 Jul 2016 00:32:16 +0530 Subject: [PATCH 1/2] [Trial] Ignore error code, stderr --- index.js | 36 ++++++++++++++++++------------------ 1 file changed, 18 insertions(+), 18 deletions(-) diff --git a/index.js b/index.js index 1c2bc59..47e3fe1 100644 --- a/index.js +++ b/index.js @@ -93,24 +93,24 @@ var PythonShell = function (script, options) { return; } var err; - if (errorData || self.exitCode !== 0) { - if (errorData) { - err = self.parseError(errorData); - } else { - err = new Error('process exited with code ' + self.exitCode); - } - err = extend(err, { - executable: pythonPath, - options: pythonOptions.length ? pythonOptions : null, - script: self.script, - args: scriptArgs.length ? scriptArgs : null, - exitCode: self.exitCode - }); - // do not emit error if only a callback is used - if (self.listeners('error').length || !self._endCallback) { - self.emit('error', err); - } - } + // if (errorData || self.exitCode !== 0) { + // if (errorData) { + // err = self.parseError(errorData); + // } else { + // err = new Error('process exited with code ' + self.exitCode); + // } + // err = extend(err, { + // executable: pythonPath, + // options: pythonOptions.length ? pythonOptions : null, + // script: self.script, + // args: scriptArgs.length ? scriptArgs : null, + // exitCode: self.exitCode + // }); + // // do not emit error if only a callback is used + // if (self.listeners('error').length || !self._endCallback) { + // self.emit('error', err); + // } + // } self.terminated = true; self.emit('close'); self._endCallback && self._endCallback(err); From 505063a3c731c24eaa18b8cb71ea4496285748c0 Mon Sep 17 00:00:00 2001 From: "Anand M.S" Date: Fri, 15 Jul 2016 00:37:06 +0530 Subject: [PATCH 2/2] [Trial] Ignore only warnings written to stderr --- index.js | 35 ++++++++++++++++++----------------- 1 file changed, 18 insertions(+), 17 deletions(-) diff --git a/index.js b/index.js index 47e3fe1..5cb1eb5 100644 --- a/index.js +++ b/index.js @@ -94,23 +94,24 @@ var PythonShell = function (script, options) { } var err; // if (errorData || self.exitCode !== 0) { - // if (errorData) { - // err = self.parseError(errorData); - // } else { - // err = new Error('process exited with code ' + self.exitCode); - // } - // err = extend(err, { - // executable: pythonPath, - // options: pythonOptions.length ? pythonOptions : null, - // script: self.script, - // args: scriptArgs.length ? scriptArgs : null, - // exitCode: self.exitCode - // }); - // // do not emit error if only a callback is used - // if (self.listeners('error').length || !self._endCallback) { - // self.emit('error', err); - // } - // } + if (self.exitCode !== 0) { + if (errorData) { + err = self.parseError(errorData); + } else { + err = new Error('process exited with code ' + self.exitCode); + } + err = extend(err, { + executable: pythonPath, + options: pythonOptions.length ? pythonOptions : null, + script: self.script, + args: scriptArgs.length ? scriptArgs : null, + exitCode: self.exitCode + }); + // do not emit error if only a callback is used + if (self.listeners('error').length || !self._endCallback) { + self.emit('error', err); + } + } self.terminated = true; self.emit('close'); self._endCallback && self._endCallback(err);