Skip to content

Commit 9afe66d

Browse files
achalsachals
committed
make format-python
Signed-off-by: Achal Shah <achals@gmail.com>
1 parent 293a2e3 commit 9afe66d

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

52 files changed

+133
-401
lines changed

‎sdk/python/feast/cli.py‎

Lines changed: 3 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -471,10 +471,7 @@ def registry_dump_command(ctx: click.Context):
471471
@click.argument("start_ts")
472472
@click.argument("end_ts")
473473
@click.option(
474-
"--views",
475-
"-v",
476-
help="Feature views to materialize",
477-
multiple=True,
474+
"--views", "-v", help="Feature views to materialize", multiple=True,
478475
)
479476
@click.pass_context
480477
def materialize_command(
@@ -501,10 +498,7 @@ def materialize_command(
501498
@cli.command("materialize-incremental")
502499
@click.argument("end_ts")
503500
@click.option(
504-
"--views",
505-
"-v",
506-
help="Feature views to incrementally materialize",
507-
multiple=True,
501+
"--views", "-v", help="Feature views to incrementally materialize", multiple=True,
508502
)
509503
@click.pass_context
510504
def materialize_incremental_command(ctx: click.Context, end_ts: str, views: List[str]):
@@ -566,9 +560,7 @@ def init_command(project_directory, minimal: bool, template: str):
566560
help="Specify a port for the server [default: 6566]",
567561
)
568562
@click.option(
569-
"--no-access-log",
570-
is_flag=True,
571-
help="Disable the Uvicorn access log.",
563+
"--no-access-log", is_flag=True, help="Disable the Uvicorn access log.",
572564
)
573565
@click.pass_context
574566
def serve_command(ctx: click.Context, host: str, port: int, no_access_log: bool):

‎sdk/python/feast/data_source.py‎

Lines changed: 3 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -42,10 +42,7 @@ class KafkaOptions:
4242
"""
4343

4444
def __init__(
45-
self,
46-
bootstrap_servers: str,
47-
message_format: StreamFormat,
48-
topic: str,
45+
self, bootstrap_servers: str, message_format: StreamFormat, topic: str,
4946
):
5047
self.bootstrap_servers = bootstrap_servers
5148
self.message_format = message_format
@@ -94,10 +91,7 @@ class KinesisOptions:
9491
"""
9592

9693
def __init__(
97-
self,
98-
record_format: StreamFormat,
99-
region: str,
100-
stream_name: str,
94+
self, record_format: StreamFormat, region: str, stream_name: str,
10195
):
10296
self.record_format = record_format
10397
self.region = region
@@ -384,9 +378,7 @@ class RequestDataSource(DataSource):
384378
schema: Dict[str, ValueType]
385379

386380
def __init__(
387-
self,
388-
name: str,
389-
schema: Dict[str, ValueType],
381+
self, name: str, schema: Dict[str, ValueType],
390382
):
391383
"""Creates a RequestDataSource object."""
392384
super().__init__(name)

‎sdk/python/feast/diff/infra_diff.py‎

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -126,8 +126,7 @@ def diff_infra_protos(
126126
infra_objects_to_delete,
127127
infra_objects_to_add,
128128
) = tag_infra_proto_objects_for_keep_delete_add(
129-
current_infra_objects,
130-
new_infra_objects,
129+
current_infra_objects, new_infra_objects,
131130
)
132131

133132
for e in infra_objects_to_add:
@@ -200,10 +199,5 @@ def diff_between(
200199
)
201200
)
202201
return InfraObjectDiff(
203-
new.name,
204-
infra_object_type,
205-
current,
206-
new,
207-
property_diffs,
208-
transition,
202+
new.name, infra_object_type, current, new, property_diffs, transition,
209203
)

‎sdk/python/feast/diff/registry_diff.py‎

Lines changed: 3 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -147,9 +147,7 @@ def diff_registry_objects(
147147

148148

149149
def extract_objects_for_keep_delete_update_add(
150-
registry: Registry,
151-
current_project: str,
152-
desired_repo_contents: RepoContents,
150+
registry: Registry, current_project: str, desired_repo_contents: RepoContents,
153151
) -> Tuple[
154152
Dict[FeastObjectType, Set[FeastObject]],
155153
Dict[FeastObjectType, Set[FeastObject]],
@@ -196,9 +194,7 @@ def extract_objects_for_keep_delete_update_add(
196194

197195

198196
def diff_between(
199-
registry: Registry,
200-
current_project: str,
201-
desired_repo_contents: RepoContents,
197+
registry: Registry, current_project: str, desired_repo_contents: RepoContents,
202198
) -> RegistryDiff:
203199
"""
204200
Returns the difference between the current and desired repo states.
@@ -291,9 +287,7 @@ def apply_diff_to_registry(
291287
BaseFeatureView, feast_object_diff.current_feast_object
292288
)
293289
registry.delete_feature_view(
294-
feature_view_obj.name,
295-
project,
296-
commit=False,
290+
feature_view_obj.name, project, commit=False,
297291
)
298292

299293
if feast_object_diff.transition_type in [

‎sdk/python/feast/driver_test_data.py‎

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -30,12 +30,7 @@ def _convert_event_timestamp(event_timestamp: pd.Timestamp, t: EventTimestampTyp
3030

3131

3232
def create_orders_df(
33-
customers,
34-
drivers,
35-
start_date,
36-
end_date,
37-
order_count,
38-
locations=None,
33+
customers, drivers, start_date, end_date, order_count, locations=None,
3934
) -> pd.DataFrame:
4035
"""
4136
Example df generated by this function (if locations):

‎sdk/python/feast/feature.py‎

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -30,10 +30,7 @@ class Feature:
3030
"""
3131

3232
def __init__(
33-
self,
34-
name: str,
35-
dtype: ValueType,
36-
labels: Optional[Dict[str, str]] = None,
33+
self, name: str, dtype: ValueType, labels: Optional[Dict[str, str]] = None,
3734
):
3835
"""Creates a Feature object."""
3936
self._name = name
@@ -94,9 +91,7 @@ def to_proto(self) -> FeatureSpecProto:
9491
value_type = ValueTypeProto.ValueType.Enum.Value(self.dtype.name)
9592

9693
return FeatureSpecProto(
97-
name=self.name,
98-
value_type=value_type,
99-
labels=self.labels,
94+
name=self.name, value_type=value_type, labels=self.labels,
10095
)
10196

10297
@classmethod

‎sdk/python/feast/feature_store.py‎

Lines changed: 11 additions & 34 deletions
Original file line numberDiff line numberDiff line change
@@ -112,9 +112,7 @@ class FeatureStore:
112112

113113
@log_exceptions
114114
def __init__(
115-
self,
116-
repo_path: Optional[str] = None,
117-
config: Optional[RepoConfig] = None,
115+
self, repo_path: Optional[str] = None, config: Optional[RepoConfig] = None,
118116
):
119117
"""
120118
Creates a FeatureStore object.
@@ -245,9 +243,7 @@ def list_request_feature_views(
245243
)
246244

247245
def _list_feature_views(
248-
self,
249-
allow_cache: bool = False,
250-
hide_dummy_entity: bool = True,
246+
self, allow_cache: bool = False, hide_dummy_entity: bool = True,
251247
) -> List[FeatureView]:
252248
feature_views = []
253249
for fv in self._registry.list_feature_views(
@@ -414,9 +410,7 @@ def delete_feature_service(self, name: str):
414410
return self._registry.delete_feature_service(name, self.project)
415411

416412
def _get_features(
417-
self,
418-
features: Union[List[str], FeatureService],
419-
allow_cache: bool = False,
413+
self, features: Union[List[str], FeatureService], allow_cache: bool = False,
420414
) -> List[str]:
421415
_features = features
422416

@@ -878,8 +872,7 @@ def get_historical_features(
878872
for feature_name in odfv_request_data_schema.keys():
879873
if feature_name not in entity_pd_df.columns:
880874
raise RequestDataNotFoundInEntityDfException(
881-
feature_name=feature_name,
882-
feature_view_name=odfv.name,
875+
feature_name=feature_name, feature_view_name=odfv.name,
883876
)
884877

885878
_validate_feature_refs(_feature_refs, full_feature_names)
@@ -992,9 +985,7 @@ def get_saved_dataset(self, name: str) -> SavedDataset:
992985

993986
@log_exceptions_and_usage
994987
def materialize_incremental(
995-
self,
996-
end_date: datetime,
997-
feature_views: Optional[List[str]] = None,
988+
self, end_date: datetime, feature_views: Optional[List[str]] = None,
998989
) -> None:
999990
"""
1000991
Materialize incremental new data from the offline store into the online store.
@@ -1081,10 +1072,7 @@ def tqdm_builder(length):
10811072
)
10821073

10831074
self._registry.apply_materialization(
1084-
feature_view,
1085-
self.project,
1086-
start_date,
1087-
end_date,
1075+
feature_view, self.project, start_date, end_date,
10881076
)
10891077

10901078
@log_exceptions_and_usage
@@ -1171,10 +1159,7 @@ def tqdm_builder(length):
11711159
)
11721160

11731161
self._registry.apply_materialization(
1174-
feature_view,
1175-
self.project,
1176-
start_date,
1177-
end_date,
1162+
feature_view, self.project, start_date, end_date,
11781163
)
11791164

11801165
@log_exceptions_and_usage
@@ -1442,17 +1427,12 @@ def _get_online_features(
14421427
for table, requested_features in grouped_refs:
14431428
# Get the correct set of entity values with the correct join keys.
14441429
table_entity_values, idxs = self._get_unique_entities(
1445-
table,
1446-
join_key_values,
1447-
entity_name_to_join_key_map,
1430+
table, join_key_values, entity_name_to_join_key_map,
14481431
)
14491432

14501433
# Fetch feature data for the minimum set of Entities.
14511434
feature_data = self._read_from_online_store(
1452-
table_entity_values,
1453-
provider,
1454-
requested_features,
1455-
table,
1435+
table_entity_values, provider, requested_features, table,
14561436
)
14571437

14581438
# Populate the result_rows with the Features from the OnlineStore inplace.
@@ -1617,9 +1597,7 @@ def _get_unique_entities(
16171597
"""
16181598
# Get the correct set of entity values with the correct join keys.
16191599
table_entity_values = self._get_table_entity_values(
1620-
table,
1621-
entity_name_to_join_key_map,
1622-
join_key_values,
1600+
table, entity_name_to_join_key_map, join_key_values,
16231601
)
16241602

16251603
# Convert back to rowise.
@@ -1804,8 +1782,7 @@ def _augment_response_with_on_demand_transforms(
18041782
for odfv_name, _feature_refs in odfv_feature_refs.items():
18051783
odfv = requested_odfv_map[odfv_name]
18061784
transformed_features_df = odfv.get_transformed_features_df(
1807-
initial_response_df,
1808-
full_feature_names,
1785+
initial_response_df, full_feature_names,
18091786
)
18101787
selected_subset = [
18111788
f for f in transformed_features_df.columns if f in _feature_refs

‎sdk/python/feast/feature_view.py‎

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -44,9 +44,7 @@
4444
DUMMY_ENTITY_NAME = "__dummy"
4545
DUMMY_ENTITY_VAL = ""
4646
DUMMY_ENTITY = Entity(
47-
name=DUMMY_ENTITY_NAME,
48-
join_key=DUMMY_ENTITY_ID,
49-
value_type=ValueType.STRING,
47+
name=DUMMY_ENTITY_NAME, join_key=DUMMY_ENTITY_ID, value_type=ValueType.STRING,
5048
)
5149

5250

‎sdk/python/feast/go_server.py‎

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -84,11 +84,7 @@ def connect(self) -> bool:
8484
else feast.__path__[0] + "/binaries/server"
8585
)
8686
# Automatically reconnect with go subprocess exits
87-
self._process = Popen(
88-
[executable],
89-
cwd=cwd,
90-
env=env,
91-
)
87+
self._process = Popen([executable], cwd=cwd, env=env,)
9288

9389
channel = grpc.insecure_channel(f"unix:{self.sock_file}")
9490
self._client = ServingServiceStub(channel)

‎sdk/python/feast/inference.py‎

Lines changed: 3 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -45,10 +45,7 @@ def update_entities_with_inferred_types_from_feature_views(
4545

4646
# get entity information from information extracted from the view batch source
4747
extracted_entity_name_type_pairs = list(
48-
filter(
49-
lambda tup: tup[0] == entity.join_key,
50-
col_names_and_types,
51-
)
48+
filter(lambda tup: tup[0] == entity.join_key, col_names_and_types,)
5249
)
5350
if len(extracted_entity_name_type_pairs) == 0:
5451
# Doesn't mention inference error because would also be an error without inferencing
@@ -57,10 +54,8 @@ def update_entities_with_inferred_types_from_feature_views(
5754
its entity's name."""
5855
)
5956

60-
inferred_value_type = (
61-
view.batch_source.source_datatype_to_feast_value_type()(
62-
extracted_entity_name_type_pairs[0][1]
63-
)
57+
inferred_value_type = view.batch_source.source_datatype_to_feast_value_type()(
58+
extracted_entity_name_type_pairs[0][1]
6459
)
6560

6661
if (

0 commit comments

Comments
 (0)