From 12f63b497b64e42a1c538d6194dd1005a418538d Mon Sep 17 00:00:00 2001 From: ddeste01 Date: Wed, 18 Oct 2023 07:29:58 -0400 Subject: [PATCH 1/2] remove parents to support table references --- .../contrib/postgres_offline_store/postgres_source.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sdk/python/feast/infra/offline_stores/contrib/postgres_offline_store/postgres_source.py b/sdk/python/feast/infra/offline_stores/contrib/postgres_offline_store/postgres_source.py index c76bd7d2f9d..9434bcf6c94 100644 --- a/sdk/python/feast/infra/offline_stores/contrib/postgres_offline_store/postgres_source.py +++ b/sdk/python/feast/infra/offline_stores/contrib/postgres_offline_store/postgres_source.py @@ -92,7 +92,7 @@ def get_table_column_names_and_types( ) def get_table_query_string(self) -> str: - return f"({self._postgres_options._query})" + return f"{self._postgres_options._query}" class PostgreSQLOptions: From 3804b25ac49d9a5094b2dd385afed4703a9735e7 Mon Sep 17 00:00:00 2001 From: ddeste01 Date: Wed, 18 Oct 2023 07:40:44 -0400 Subject: [PATCH 2/2] remove parens from postgres retrieval job query --- .../offline_stores/contrib/postgres_offline_store/postgres.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sdk/python/feast/infra/offline_stores/contrib/postgres_offline_store/postgres.py b/sdk/python/feast/infra/offline_stores/contrib/postgres_offline_store/postgres.py index f2aa535c1d4..7af763f6afb 100644 --- a/sdk/python/feast/infra/offline_stores/contrib/postgres_offline_store/postgres.py +++ b/sdk/python/feast/infra/offline_stores/contrib/postgres_offline_store/postgres.py @@ -88,7 +88,7 @@ def pull_latest_from_table_or_query( FROM ( SELECT {a_field_string}, ROW_NUMBER() OVER({partition_by_join_key_string} ORDER BY {timestamp_desc_string}) AS _feast_row - FROM ({from_expression}) a + FROM {from_expression} a WHERE a."{timestamp_field}" BETWEEN '{start_date}'::timestamptz AND '{end_date}'::timestamptz ) b WHERE _feast_row = 1