From 7ca70826f6eab0059dfa2e903fecf6cfff851d30 Mon Sep 17 00:00:00 2001 From: Chester Ong Date: Fri, 16 Feb 2024 12:08:09 +0800 Subject: [PATCH 1/2] using version args to install the correct feast version Signed-off-by: Chester Ong --- .../feast/infra/feature_servers/multicloud/Dockerfile | 7 +++++-- .../feast/infra/feature_servers/multicloud/Dockerfile.dev | 8 +++++--- 2 files changed, 10 insertions(+), 5 deletions(-) diff --git a/sdk/python/feast/infra/feature_servers/multicloud/Dockerfile b/sdk/python/feast/infra/feature_servers/multicloud/Dockerfile index fdd8e3ac51d..4527c5b1566 100644 --- a/sdk/python/feast/infra/feature_servers/multicloud/Dockerfile +++ b/sdk/python/feast/infra/feature_servers/multicloud/Dockerfile @@ -1,5 +1,9 @@ FROM python:3.8 +# Input the feast version to install +# This requires feast package to be available in pypi before building this image +ARG VERSION + RUN apt update && \ apt install -y \ jq \ @@ -7,8 +11,7 @@ RUN apt update && \ build-essential RUN pip install pip --upgrade -RUN pip install "feast[aws,gcp,snowflake,redis,go,mysql,postgres]" - +RUN pip install "feast[aws,gcp,snowflake,redis,go,mysql,postgres]==${VERSION}" RUN apt update RUN apt install -y -V ca-certificates lsb-release wget diff --git a/sdk/python/feast/infra/feature_servers/multicloud/Dockerfile.dev b/sdk/python/feast/infra/feature_servers/multicloud/Dockerfile.dev index 3fc1355d7a8..4527c5b1566 100644 --- a/sdk/python/feast/infra/feature_servers/multicloud/Dockerfile.dev +++ b/sdk/python/feast/infra/feature_servers/multicloud/Dockerfile.dev @@ -1,5 +1,9 @@ FROM python:3.8 +# Input the feast version to install +# This requires feast package to be available in pypi before building this image +ARG VERSION + RUN apt update && \ apt install -y \ jq \ @@ -7,9 +11,7 @@ RUN apt update && \ build-essential RUN pip install pip --upgrade -COPY . . - -RUN pip install "feast[aws,gcp,snowflake,redis,go,mysql,postgres]" +RUN pip install "feast[aws,gcp,snowflake,redis,go,mysql,postgres]==${VERSION}" RUN apt update RUN apt install -y -V ca-certificates lsb-release wget From 00f6bec9910c17ccd769720a8ecfcc0bc8726689 Mon Sep 17 00:00:00 2001 From: Chester Ong Date: Tue, 20 Feb 2024 09:06:16 +0800 Subject: [PATCH 2/2] revert the COPY command Signed-off-by: Chester Ong --- .../feast/infra/feature_servers/multicloud/Dockerfile.dev | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/sdk/python/feast/infra/feature_servers/multicloud/Dockerfile.dev b/sdk/python/feast/infra/feature_servers/multicloud/Dockerfile.dev index 4527c5b1566..015e3c7ee82 100644 --- a/sdk/python/feast/infra/feature_servers/multicloud/Dockerfile.dev +++ b/sdk/python/feast/infra/feature_servers/multicloud/Dockerfile.dev @@ -11,6 +11,8 @@ RUN apt update && \ build-essential RUN pip install pip --upgrade +COPY . . + RUN pip install "feast[aws,gcp,snowflake,redis,go,mysql,postgres]==${VERSION}" RUN apt update @@ -18,4 +20,4 @@ RUN apt install -y -V ca-certificates lsb-release wget RUN wget https://apache.jfrog.io/artifactory/arrow/$(lsb_release --id --short | tr 'A-Z' 'a-z')/apache-arrow-apt-source-latest-$(lsb_release --codename --short).deb RUN apt install -y -V ./apache-arrow-apt-source-latest-$(lsb_release --codename --short).deb RUN apt update -RUN apt -y install libarrow-dev \ No newline at end of file +RUN apt -y install libarrow-dev