From 984ed5f8aa6160ba8b6fdfab915cf804341bc55c Mon Sep 17 00:00:00 2001 From: Francisco Arceo Date: Fri, 3 Jan 2025 12:58:53 -0500 Subject: [PATCH 1/2] Add Milvus to pr_integration_tests.yml --- .github/workflows/pr_integration_tests.yml | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/.github/workflows/pr_integration_tests.yml b/.github/workflows/pr_integration_tests.yml index 923c0b0335b..e30587889db 100644 --- a/.github/workflows/pr_integration_tests.yml +++ b/.github/workflows/pr_integration_tests.yml @@ -45,6 +45,10 @@ jobs: --health-interval 10s --health-timeout 5s --health-retries 5 + milvus: + image: milvus + ports: + - 19530:19530 steps: - uses: actions/checkout@v4 with: @@ -95,6 +99,10 @@ jobs: run: | docker pull vishnunair/docker-redis-cluster:latest docker run -d -p 6001:6379 -p 6002:6380 -p 6003:6381 -p 6004:6382 -p 6005:6383 -p 6006:6384 --name redis-cluster vishnunair/docker-redis-cluster + - name: Setup Milvus Cluster + run: | + wget https://github.com/milvus-io/milvus/releases/download/v2.4.20/milvus-standalone-docker-compose.yml -O docker-compose.yml + docker compose up -d - name: Test python if: ${{ always() }} # this will guarantee that step won't be canceled and resources won't leak env: From dcd0a83c1c6d6a7f7cfbd1682c9ca197c0c37c2b Mon Sep 17 00:00:00 2001 From: Francisco Arceo Date: Fri, 3 Jan 2025 14:36:15 -0500 Subject: [PATCH 2/2] upgrading to v2.5.1 and removing milvus service key --- .github/workflows/pr_integration_tests.yml | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/.github/workflows/pr_integration_tests.yml b/.github/workflows/pr_integration_tests.yml index e30587889db..edf92e7e786 100644 --- a/.github/workflows/pr_integration_tests.yml +++ b/.github/workflows/pr_integration_tests.yml @@ -45,10 +45,6 @@ jobs: --health-interval 10s --health-timeout 5s --health-retries 5 - milvus: - image: milvus - ports: - - 19530:19530 steps: - uses: actions/checkout@v4 with: @@ -101,7 +97,7 @@ jobs: docker run -d -p 6001:6379 -p 6002:6380 -p 6003:6381 -p 6004:6382 -p 6005:6383 -p 6006:6384 --name redis-cluster vishnunair/docker-redis-cluster - name: Setup Milvus Cluster run: | - wget https://github.com/milvus-io/milvus/releases/download/v2.4.20/milvus-standalone-docker-compose.yml -O docker-compose.yml + wget https://github.com/milvus-io/milvus/releases/download/v2.5.1/milvus-standalone-docker-compose.yml -O docker-compose.yml docker compose up -d - name: Test python if: ${{ always() }} # this will guarantee that step won't be canceled and resources won't leak