ref(litellm): Remove set_data_normalized for primitive attributes#5514
Draft
alexander-alderman-webb wants to merge 1 commit intomasterfrom
Draft
ref(litellm): Remove set_data_normalized for primitive attributes#5514alexander-alderman-webb wants to merge 1 commit intomasterfrom
set_data_normalized for primitive attributes#5514alexander-alderman-webb wants to merge 1 commit intomasterfrom
Conversation
Contributor
Codecov Results 📊✅ 13 passed | Total: 13 | Pass Rate: 100% | Execution Time: 7.78s All tests are passing successfully. ❌ Patch coverage is 0.00%. Project has 13688 uncovered lines. Files with missing lines (180)
Generated by Codecov Action |
Contributor
Semver Impact of This PR🟢 Patch (bug fixes) 📋 Changelog PreviewThis is how your changes will appear in the changelog. Bug Fixes 🐛Openai
Other
Documentation 📚
Internal Changes 🔧
🤖 This preview updates automatically when you update the PR. |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
| for key, value in litellm_params.items(): | ||
| if value is not None: | ||
| set_data_normalized(span, f"gen_ai.litellm.{key}", value) | ||
| span.set_data(f"gen_ai.litellm.{key}", value) |
There was a problem hiding this comment.
Non-serializable span data now possible
Medium Severity
Replacing set_data_normalized() with span.set_data() can store non-JSON-serializable values from kwargs (or completion_response.model) directly into Span._data. If any of these values are pydantic objects, enums, or other custom types, span serialization may fail or produce unexpected payloads when sending events.
Additional Locations (1)
Contributor
Author
There was a problem hiding this comment.
The types of these attributes are strings, it's api_base, api_version and custom_llm_provider.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Remove
set_data_normalized()for attributes that do not require normalization.Issues
Reminders
tox -e linters.feat:,fix:,ref:,meta:)