C#: Improve BMN feed checking & handling.#21684
Draft
michaelnebel wants to merge 16 commits intogithub:mainfrom
Draft
C#: Improve BMN feed checking & handling.#21684michaelnebel wants to merge 16 commits intogithub:mainfrom
michaelnebel wants to merge 16 commits intogithub:mainfrom
Conversation
…plicit this qualifiers.
…pecific sources for restoring if private registries are used of if nuget feed reachability check is performed.
…on an environment variable setting) are still used as sources.
csharp/extractor/Semmle.Extraction.CSharp.DependencyFetching/NugetPackageRestorer.cs
Fixed
Show fixed
Hide fixed
…se unless there is a timeout when trying to reach them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR we make some improvements to the C# NuGet feed check and use of private registries.
The primary change in this PR, is that
dotnet restore(both for projects and solutions) which overrides the use ofnuget.configfiles (unless nuget feed reachability check is disabled and no private registries are configured).dotnet restoreto make sure that we include the private registries. This list now includes all feeds or reachable feeds as well (depending on whether we check nuget feed reachability).