perf(bigframes): Improve write api upload throughput#16641
Merged
TrevorBergeron merged 4 commits intomainfrom Apr 14, 2026
Merged
perf(bigframes): Improve write api upload throughput#16641TrevorBergeron merged 4 commits intomainfrom
TrevorBergeron merged 4 commits intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the stream_worker function in loader.py to use AppendRowsStream and a futures-based approach for appending rows to BigQuery, which introduces concurrency control via a max_outstanding parameter. The review feedback identifies a regression where row-level errors are no longer checked, potentially leading to silent data loss, and suggests using a try...finally block to ensure the stream manager is properly closed.
sycai
approved these changes
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 🦕