Skip to content
This repository was archived by the owner on Jul 6, 2023. It is now read-only.

feat: Add support for disabling Pod overprovisioning in the progressive deployment strategy configuration for a Kubernetes Target #168

Closed
gcf-owl-bot wants to merge 2 commits into from
Closed

feat: Add support for disabling Pod overprovisioning in the progressive deployment strategy configuration for a Kubernetes Target #168

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
11aea83
feat: Add support for disabling Pod overprovisioning in the progressi…
gcf-owl-bot[bot] Jun 5, 2023
d9f0556
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] Jun 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 13 additions & 3 deletions google/cloud/deploy_v1/types/cloud_deploy.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -552,6 +552,13 @@ class ServiceNetworking(proto.Message):
Required. Name of the Kubernetes Deployment
whose traffic is managed by the specified
Service.
disable_pod_overprovisioning (bool):
Optional. Whether to disable Pod
overprovisioning. If Pod overprovisioning is
disabled then Cloud Deploy will limit the number
of total Pods used for the deployment strategy
to the number of Pods the Deployment has on the
cluster.
"""

service: str = proto.Field(
Expand All @@ -562,6 +569,10 @@ class ServiceNetworking(proto.Message):
proto.STRING,
number=2,
)
disable_pod_overprovisioning: bool = proto.Field(
proto.BOOL,
number=3,
)

gateway_service_mesh: GatewayServiceMesh = proto.Field(
proto.MESSAGE,
Expand Down Expand Up @@ -1690,9 +1701,8 @@ class DeleteTargetRequest(proto.Message):
exception that zero UUID is not supported
(00000000-0000-0000-0000-000000000000).
allow_missing (bool):
Optional. If set to true, then deleting an
already deleted or non-existing DeliveryPipeline
will succeed.
Optional. If set to true, then deleting an already deleted
or non-existing ``Target`` will succeed.
validate_only (bool):
Optional. If set, validate the request and
preview the review, but do not actually post it.
Expand Down
2 changes: 1 addition & 1 deletion samples/generated_samples/snippet_metadata_google.cloud.deploy.v1.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
],
"language": "PYTHON",
"name": "google-cloud-deploy",
"version": "1.9.0"
"version": "0.1.0"
},
"snippets": [
{
Expand Down
6 changes: 6 additions & 0 deletions tests/unit/gapic/deploy_v1/test_cloud_deploy.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8651,6 +8651,7 @@ def test_create_delivery_pipeline_rest(request_type):
"service_networking": {
"service": "service_value",
"deployment": "deployment_value",
"disable_pod_overprovisioning": True,
},
},
"cloud_run": {"automatic_traffic_control": True},
Expand Down Expand Up @@ -8930,6 +8931,7 @@ def test_create_delivery_pipeline_rest_bad_request(
"service_networking": {
"service": "service_value",
"deployment": "deployment_value",
"disable_pod_overprovisioning": True,
},
},
"cloud_run": {"automatic_traffic_control": True},
Expand Down Expand Up @@ -9095,6 +9097,7 @@ def test_update_delivery_pipeline_rest(request_type):
"service_networking": {
"service": "service_value",
"deployment": "deployment_value",
"disable_pod_overprovisioning": True,
},
},
"cloud_run": {"automatic_traffic_control": True},
Expand Down Expand Up @@ -9359,6 +9362,7 @@ def test_update_delivery_pipeline_rest_bad_request(
"service_networking": {
"service": "service_value",
"deployment": "deployment_value",
"disable_pod_overprovisioning": True,
},
},
"cloud_run": {"automatic_traffic_control": True},
Expand Down Expand Up @@ -12089,6 +12093,7 @@ def test_create_release_rest(request_type):
"service_networking": {
"service": "service_value",
"deployment": "deployment_value",
"disable_pod_overprovisioning": True,
},
},
"cloud_run": {"automatic_traffic_control": True},
Expand Down Expand Up @@ -12437,6 +12442,7 @@ def test_create_release_rest_bad_request(
"service_networking": {
"service": "service_value",
"deployment": "deployment_value",
"disable_pod_overprovisioning": True,
},
},
"cloud_run": {"automatic_traffic_control": True},
Expand Down