Adding nice options for subscriptions and #15

jeffharrell · jeffharrell · commit 58054efe4dae · 2013-03-10T23:51:46.000-07:00
diff --git a/src/paypal-button.js b/src/paypal-button.js
@@ -18,7 +18,9 @@ PAYPAL.apps = PAYPAL.apps || {};
 			id: "hosted_button_id",
 			name: "item_name",
 			number: "item_number",
-			lang: "lc"
+			lang: "lc",
+			recurrence: "p3",
+			period: "t3"
 		},
 		buttonImgs = {
 			buynow: "//www.paypalobjects.com/{locale}/i/btn/btn_buynow_{size}.gif",
@@ -89,6 +91,12 @@ PAYPAL.apps = PAYPAL.apps || {};
 			// Subscribe buttons
 			} else if (type === "subscribe") {
 				data.add("cmd", "_xclick-subscriptions");
+
+				// TODO: "amount cannot be used in prettyParams since it's overloaded
+				// Find a better way to do this
+				if (data.items.amount && !data.items.a3) {
+					data.add("a3", data.items.amount.value);
+				}
 			// Buy Now buttons
 			} else {
 				data.add("cmd", "_xclick");
diff --git a/test/index.html b/test/index.html
@@ -113,11 +113,10 @@ <h2>Subscribe (Small)</h2>
 		<script src="../src/paypal-button.js?merchant=6XF3MPZBZV6HU"
 		    data-button="subscribe"
 		    data-name="Subscribe!"
-		    data-amount="1.00"
 		    data-size="small"
-		    data-a3="1.00"
-		    data-p3="1"
-		    data-t3="M"
+		    data-amount="1.00"
+		    data-recurrence="1"
+		    data-period="M"
 		></script>
 	</div>
 
@@ -127,7 +126,8 @@ <h2>Subscribe (Large)</h2>
 		    data-button="subscribe"
 		    data-name="Subscribe!"
 		    data-amount="1.00"
-		    data-size="large"
+		    data-recurrence="1"
+		    data-period="M"
 		></script>
 	</div>
 
