diff --git a/.build_1493180045112/package.json b/.build_1493180045112/package.json new file mode 100644 index 00000000..66dc9051 --- /dev/null +++ b/.build_1493180045112/package.json @@ -0,0 +1 @@ +undefined \ No newline at end of file diff --git a/.build_1493180045112/testa b/.build_1493180045112/testa new file mode 100644 index 00000000..66dc9051 --- /dev/null +++ b/.build_1493180045112/testa @@ -0,0 +1 @@ +undefined \ No newline at end of file diff --git a/.build_1493180045214/package.json b/.build_1493180045214/package.json new file mode 100644 index 00000000..66dc9051 --- /dev/null +++ b/.build_1493180045214/package.json @@ -0,0 +1 @@ +undefined \ No newline at end of file diff --git a/.build_1493180045214/testa b/.build_1493180045214/testa new file mode 100644 index 00000000..66dc9051 --- /dev/null +++ b/.build_1493180045214/testa @@ -0,0 +1 @@ +undefined \ No newline at end of file diff --git a/lib/main.js b/lib/main.js index 8c6235be..5c67ea7d 100644 --- a/lib/main.js +++ b/lib/main.js @@ -131,13 +131,15 @@ Lambda.prototype._params = function (program, buffer) { Variables: config } } - if (program.deadLetterConfigTargetArn !== undefined) { + if (program.deadLetterConfigTargetArn !== undefined && program.deadLetterConfigTargetArn !== '' && program.deadLetterConfigTargetArn !== null) { params.DeadLetterConfig = { TargetArn: program.deadLetterConfigTargetArn }; } - if (program.tracingConfig) { + if (program.tracingConfig !== undefined && program.tracingConfig !== '' && program.tracingConfig !== null) { params.TracingConfig.Mode = program.tracingConfig; + } else { + delete params.TracingConfig; } return params; diff --git a/test/main.js b/test/main.js index 34e27d78..9dd3c47f 100644 --- a/test/main.js +++ b/test/main.js @@ -85,7 +85,7 @@ describe('node-lambda', function () { }); it('appends DeadLetterConfig to params when DLQ params set', function() { - ['', 'arn:aws:sqs:test'].forEach(function(v) { + ['arn:aws:sqs:test'].forEach(function(v) { program.deadLetterConfigTargetArn = v; const params = lambda._params(program); assert.equal(params.DeadLetterConfig.TargetArn, v, v); @@ -107,7 +107,7 @@ describe('node-lambda', function () { it('does not append TracingConfig when params are not set', function() { program.tracingConfig = ''; const params = lambda._params(program); - assert.isNull(params.TracingConfig.Mode); + assert.isUndefined(params.TracingConfig); }); describe('configFile', function () {