assert,util: fix deep comparing invalid dates skipping properties

BridgeAR · aduh95 · commit e5558b0859d1 · 2026-04-08T23:52:59.000+02:00
The property comparison of invalid dates regressed when starting to handle invalid dates as being equal. PR-URL: #61076 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
diff --git a/lib/internal/util/comparisons.js b/lib/internal/util/comparisons.js
@@ -302,6 +302,12 @@ function objectComparisonStart(val1, val2, mode, memos) {
         DatePrototypeGetTime(val1) !== DatePrototypeGetTime(val2)) {
       return false;
     }
+    const time1 = DatePrototypeGetTime(val1);
+    const time2 = DatePrototypeGetTime(val2);
+    // eslint-disable-next-line no-self-compare
+    if (time1 !== time2 && (time1 === time1 || time2 === time2)) {
+      return false;
+    }
   } else if (isRegExp(val1)) {
     if (!isRegExp(val2) || !areSimilarRegExps(val1, val2)) {
       return false;
diff --git a/test/parallel/test-assert-deep.js b/test/parallel/test-assert-deep.js
@@ -779,6 +779,19 @@ test('Additional tests', () => {
 
   assertNotDeepOrStrict(new Date(), new Date(2000, 3, 14));
 
+  {
+    // Invalid dates deep comparison.
+    const date1 = new Date('foo');
+    const date2 = new Date('bar');
+    date1.foo = true;
+    date2.foo = true;
+    assertDeepAndStrictEqual(date1, date2);
+
+    date1.bar = false;
+    date2.bar = true;
+    assertNotDeepOrStrict(date1, date2);
+  }
+
   assertDeepAndStrictEqual(/a/, /a/);
   assertDeepAndStrictEqual(/a/g, /a/g);
   assertDeepAndStrictEqual(/a/i, /a/i);
