Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: openstack/puppet-openstacklib
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: openstack/puppet-openstacklib
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: stable/2024.2
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 5 commits
  • 8 files changed
  • 3 contributors

Commits on Oct 4, 2024

  1. Update .gitreview for stable/2024.2 

    Change-Id: If6b98d77d6ecdbaf0460e52b5a7725e116e2d4b1
    @openstackadmin
    openstackadmin committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    30480a1 View commit details
    Browse the repository at this point in the history

  2. Update TOX_CONSTRAINTS_FILE for stable/2024.2 

    Update the URL to the upper-constraints file to point to the redirect
rule on releases.openstack.org so that anyone working on this branch
will switch to the correct upper-constraints list automatically when
the requirements repository branches.

Until the requirements repository has as stable/2024.2 branch, tests will
continue to use the upper-constraints list on master.

Change-Id: I7918c2b3593fe76ed4d050c3c7f1e224004eea89
    @openstackadmin
    openstackadmin committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    b3292c3 View commit details
    Browse the repository at this point in the history

Commits on Feb 19, 2025

  1. Replace remaining use of legacy facts 

    ... because these are no longer available in Puppet 8.

Change-Id: Ic1f11b7e12d35f7381d621c6f28636a34ca14e0e
(cherry picked from commit ee48d7a)
    @kajinamit
    kajinamit committed Feb 19, 2025
    Configuration menu
    Copy the full SHA
    a1f3e5a View commit details
    Browse the repository at this point in the history

Commits on Apr 8, 2025

  1. Replace deprecated File.exists? 

    File.exists? has been deprecated since Ruby 2.1, in favor of
File.exist? .

Change-Id: I2ca024bd0c808e026a9f6f8e33842e8a501b9a10
(cherry picked from commit 4585100)
    @kajinamit
    kajinamit committed Apr 8, 2025
    Configuration menu
    Copy the full SHA
    0b584c8 View commit details
    Browse the repository at this point in the history

Commits on Nov 25, 2025

  1. Replace Puppet::Util::withenv with custom version 

    ... that filters out OS_* environment variables
from the existing copied ENV and then set the
passed environment variables to ENV and yield
to the openstack CLI call.

This has been a problem for a very long this
where if you source OS_* environment in your
shell and try to run Puppet the openstack CLI
calls executed by the Puppet modules will
pick up these environment variables causing
side effects such as `openstack token issue`
commands failing to test password for keystone_user
resources causing a `openstack uset set` command
even though the password has not changed.

Conflicts:
	spec/unit/provider/openstack_spec.rb

Change-Id: Ic4f9d7f7e8faf5ba5caaade49f10789aa8dba864
Signed-off-by: Tobias Urdin <tobias.urdin@binero.com>
(cherry picked from commit 864f02d)
(cherry picked from commit 2e85937)
(cherry picked from commit 12557ed)
    @tobias-urdin @kajinamit
    tobias-urdin authored and kajinamit committed Nov 25, 2025
    Configuration menu
    Copy the full SHA
    98e64c6 View commit details
    Browse the repository at this point in the history
Loading