Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: jamis/bulk_insert
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: procore/bulk_insert
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 12 commits
  • 7 files changed
  • 1 contributor

Commits on Mar 9, 2018

  1. return ids in BulkInsert::Worker

    Peter Loomis committed Mar 9, 2018
    Configuration menu
    Copy the full SHA
    ff7bfca View commit details
    Browse the repository at this point in the history

  2. integration tests

    Peter Loomis committed Mar 9, 2018
    Configuration menu
    Copy the full SHA
    4976741 View commit details
    Browse the repository at this point in the history

  3. undo change to what is returned when empty block

    Peter Loomis committed Mar 9, 2018
    Configuration menu
    Copy the full SHA
    fef402c View commit details
    Browse the repository at this point in the history

Commits on Mar 10, 2018

  1. fix liskov violation

    Peter Loomis committed Mar 10, 2018
    Configuration menu
    Copy the full SHA
    8f48764 View commit details
    Browse the repository at this point in the history

  2. use array concat so as to not allocate a new array on every save

    Peter Loomis committed Mar 10, 2018
    Configuration menu
    Copy the full SHA
    334174d View commit details
    Browse the repository at this point in the history

  3. store result_sets, not results

    Peter Loomis committed Mar 10, 2018
    Configuration menu
    Copy the full SHA
    ad6f4e6 View commit details
    Browse the repository at this point in the history

Commits on Mar 13, 2018

  1. fix type in spec

    Peter Loomis committed Mar 13, 2018
    Configuration menu
    Copy the full SHA
    6eae2c1 View commit details
    Browse the repository at this point in the history

Commits on Mar 14, 2018

  1. make return of primary keys opt-in

    Peter Loomis committed Mar 14, 2018
    Configuration menu
    Copy the full SHA
    7c0a06c View commit details
    Browse the repository at this point in the history

  2. make return of primary keys opt-in

    Peter Loomis committed Mar 14, 2018
    Configuration menu
    Copy the full SHA
    c4bfb35 View commit details
    Browse the repository at this point in the history

  3. use exec_query instead of execute

    Peter Loomis committed Mar 14, 2018
    Configuration menu
    Copy the full SHA
    ec27cac View commit details
    Browse the repository at this point in the history

  4. remove redundant self

    Peter Loomis committed Mar 14, 2018
    Configuration menu
    Copy the full SHA
    b355108 View commit details
    Browse the repository at this point in the history

Commits on Mar 19, 2018

  1. Merge pull request #1 from procore/make_query_return_ids 

    Modify worker query to return ids of inserted records
    Peter Loomis authored Mar 19, 2018
    Configuration menu
    Copy the full SHA
    7322020 View commit details
    Browse the repository at this point in the history
Loading