-
-
Notifications
You must be signed in to change notification settings - Fork 34.1k
Open
Labels
buildThe build process and cross-buildThe build process and cross-buildinfraCI, GitHub Actions, buildbots, Dependabot, etc.CI, GitHub Actions, buildbots, Dependabot, etc.type-refactorCode refactoring (with no changes in behavior)Code refactoring (with no changes in behavior)
Description
Description
I was checking whether there would be any ways to speed CI builds up and I know caching can help. I was surprised to see that currently, the GHA configuration mentions ccache and adds it to PATH but doesn't seem to use it anywhere else.
- name: Add ccache to PATH
run: |
echo "PATH=/usr/lib/ccache:$PATH" >> "$GITHUB_ENV"It seems like caching was used at some point to cache build artifacts, but GH-139596 says that caching is unsafe and removed actual caching from GHA.
I feel like we should just remove the Add ccache to PATH step altogether at this point (even though it doesn't really cost anything to have it), as it muddies the waters about whether we expect to cache or not.
Linked PRs
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
buildThe build process and cross-buildThe build process and cross-buildinfraCI, GitHub Actions, buildbots, Dependabot, etc.CI, GitHub Actions, buildbots, Dependabot, etc.type-refactorCode refactoring (with no changes in behavior)Code refactoring (with no changes in behavior)