code_richcompare swallows errors #146199
Description
Bug report
Bug description:
This is a sub-issue for #146102 and more details can be found here.
In code_richcompare on line 2608, PyObject_RichCompareBool can return an error (-1), but that is treated incorrectly since !(-1) == 0 . Reproducer:
class BadStr(str):
_armed = False
def __eq__(self, other):
if BadStr._armed and isinstance(other, str) and str.__eq__(self, other):
raise RuntimeError("Poison!")
return str.__eq__(self, other)
def __hash__(self): return str.__hash__(self)
c1 = compile("pass", "test", "exec")
c2 = c1.replace(co_name=BadStr("poison"))
c3 = compile("pass", "poison", "exec")
BadStr._armed = True
c2 == c3 # assertion: !_PyErr_Occurred(tstate)CPython versions tested on:
CPython main branch
Operating systems tested on:
Linux