gh-95077: [Enum] add code-based deprecation warnings for member.member access#95083
Merged
ethanfurman merged 9 commits intopython:mainfrom Jul 25, 2022
Merged
gh-95077: [Enum] add code-based deprecation warnings for member.member access#95083ethanfurman merged 9 commits intopython:mainfrom
ethanfurman merged 9 commits intopython:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The performance speed-up added in 3.11 is removed as other improvements in Python have made it unnecessary. With that removal, it is now possible to detect when a
member.memberaccess is attempted, and issue a warning before returning the desired member.Each enum member is represented in the enum class dict by a custom
enum.property. The enum member itself lives in both_member_map_andenum.property, enablingenum.propertyto skip the_member_map_lookup.enum.propertyis a subclass oftypes.DynamicClassAttributeto enableinspect, etc., to properly investigate and document enum members and attributes (althoughenum.propertyworks completely differently).