gh-142731: fix re-entrant __hash__ UAF in setattr/delattr paths#144937
Closed
harshang03 wants to merge 1 commit intopython:mainfrom
Closed
gh-142731: fix re-entrant __hash__ UAF in setattr/delattr paths#144937harshang03 wants to merge 1 commit intopython:mainfrom
harshang03 wants to merge 1 commit intopython:mainfrom
Conversation
|
The following commit authors need to sign the Contributor License Agreement: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request title
gh-142731: Fix re-entrant hash UAF in setattr/delattr paths
Summary
Fixes a use-after-free in dict attribute write/delete paths when
__hash__is re-entered and mutates state during lookup.What changed
__hash__behavior for both setattr and delattr flows.builtin_delattr_implandbuiltin_setattr_implvia re-entrant__hash__#142731.Issue
builtin_delattr_implandbuiltin_setattr_implvia re-entrant__hash__#142731Testing
issue #142731