gh-145117: Fix pprint.isreadable() returning True for inf/nan#145120
Open
zetzschest wants to merge 2 commits intopython:mainfrom
Open
gh-145117: Fix pprint.isreadable() returning True for inf/nan#145120zetzschest wants to merge 2 commits intopython:mainfrom
zetzschest wants to merge 2 commits intopython:mainfrom
Conversation
inf, -inf, nan repr strings are not valid Python literals so eval() fails on them. Check repr string inside _builtin_scalars branch instead of using math.isinf/isnan.
|
All commit authors signed the Contributor License Agreement. |
skirpichev
reviewed
Feb 23, 2026
| if typ in _builtin_scalars: | ||
| return repr(object), True, False | ||
| rep = repr(object) | ||
| if typ is float and rep in ("inf", "-inf", "nan"): |
Member
There was a problem hiding this comment.
This "problem" affects also complex numbers. You could use cmath.isfinite() to handle both cases.
Though, as I said in the issue thread - this looks rather as a documentation issue for me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
pprint.isreadable()returnsTrueforfloat('inf'),float('-inf'), andfloat('nan'), but theirrepr()values are not valid Python literals —eval()raisesNameError. The documented contract ofisreadableis that the representation can be used to recreate the value viaeval().Reproducer
Fix
In
Lib/pprint.py, in_safe_repr, add a check for float specials and returnreadable=Falsefor them.