Fix bugs in compute-changes.py logic for CIFuzz#145232
Open
StanFromIreland wants to merge 5 commits intopython:mainfrom
Open
Fix bugs in compute-changes.py logic for CIFuzz#145232StanFromIreland wants to merge 5 commits intopython:mainfrom
compute-changes.py logic for CIFuzz#145232StanFromIreland wants to merge 5 commits intopython:mainfrom
Conversation
sethmlarson
approved these changes
Feb 25, 2026
This reverts commit a61fb9b.
Member
Author
|
My manual test passed (see https://github.com/python/cpython/actions/runs/22412874770/job/64890788391?pr=145232), adding one to the suite will be too messy IMO, it would require quite a lot of patching/mocking. |
Member
|
Could you test that |
webknjaz
approved these changes
Feb 26, 2026
Member
webknjaz
left a comment
There was a problem hiding this comment.
Looks good, provided you add that test Hugo asked for.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a typo, it isn't running when
unicodedata.cis modified, e.g. this run.And, it also isn't setting
run_ci_fuzz=truewhen it should be, see same run as above.Testing this is a little messy.