Skip to content

gh-135329: Remove flaky test_repl_eio test#145932

Merged
colesbury merged 2 commits intopython:mainfrom
colesbury:gh-135329-remove-flaky-test
Mar 16, 2026
Merged

gh-135329: Remove flaky test_repl_eio test#145932
colesbury merged 2 commits intopython:mainfrom
colesbury:gh-135329-remove-flaky-test

Conversation

@colesbury
Copy link
Contributor

@colesbury colesbury commented Mar 13, 2026

The test doesn't actually test any pyrepl code (it runs Python with -S) and has a race condition that causes intermittent timeouts on CI.

See also #145793.

The test doesn't actually test any pyrepl code (it runs Python with
-S) and has a race condition that causes intermittent timeouts on CI.
@colesbury colesbury marked this pull request as ready for review March 14, 2026 00:05
@colesbury colesbury requested review from cmaloney and vstinner March 14, 2026 00:05
@colesbury colesbury added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Mar 14, 2026
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@colesbury colesbury merged commit e18abc6 into python:main Mar 16, 2026
59 checks passed
@colesbury colesbury deleted the gh-135329-remove-flaky-test branch March 16, 2026 15:08
@miss-islington-app
Copy link

Thanks @colesbury for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 16, 2026
The test doesn't actually test any pyrepl code (it runs Python with -S)
and has a race condition that causes intermittent timeouts on CI.
(cherry picked from commit e18abc6)

Co-authored-by: Sam Gross <colesbury@gmail.com>
@miss-islington-app
Copy link

Sorry, @colesbury, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker e18abc6a1f1b60434b529d4c1ff4855acde0fd13 3.13

@bedevere-app
Copy link

bedevere-app bot commented Mar 16, 2026

GH-146028 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label Mar 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants