GH-126910: Revert "Make _Py_get_machine_stack_pointer return the stack pointer (#147945)"#147994
GH-126910: Revert "Make _Py_get_machine_stack_pointer return the stack pointer (#147945)"#147994encukou merged 1 commit intopython:mainfrom
_Py_get_machine_stack_pointer return the stack pointer (#147945)"#147994Conversation
…the stack pointer (python#147945)" This reverts commit 255026d.
|
!buildbot AMD64.CentOS9.NoGIL |
|
🤖 New build scheduled with the buildbot fleet by @encukou for commit 6803150 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F147994%2Fmerge The command will test the builders whose names match following regular expression: The builders matched are:
|
|
@Fidget-Spinner @markshannon Are you able to investigate/fix this today? |
|
I can't reproduce the failure on either fedora x86-64 or ubuntu Aarch64. Note, that #147945 doesn't change the way frames are laid out or any aspect of the program, except:
Does CentOS have a glibc missing a way to tell the stack size? I want to try increasing the estimated stack size a bit, as I suspect the combination of debug build, no-gil and perf trampolines is causing the stack to grow very fast. |
|
It doesn't look like it is a stack issue. It looks like @pablogsal any idea why |
markshannon
left a comment
There was a problem hiding this comment.
@encukou go ahead with the revert. I doubt this will be fixed before the weekend
|
I also can't reproduce on a centos container (on a Fedora kernel). |
This reverts commit 255026d.
I suspect this commit broke a tier-1 buildbot; I'll use this PR to confirm.
Per PEP-11, any breakage should be fixed or reverted immediately.