Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: python-escpos/python-escpos
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: python-escpos/python-escpos
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: brb-ean-example-fix
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 3 commits
  • 5 files changed
  • 2 contributors

Commits on Jun 30, 2019

  1. AUTHORS: Adding Brian Redbeard to AUTHORS 

    As per `CONTRIBUTING.rst` including a commit for Brian 'redbeard'
Harrington to AUTHORS
    @brianredbeard
    brianredbeard committed Jun 30, 2019
    Configuration menu
    Copy the full SHA
    fb82e5d View commit details
    Browse the repository at this point in the history

  2. bug/doc: Fix invalid EAN-13 barcode in examples 

    In the various examples and python-escpos CLI there are a number of uses
of `13243546557687` as an EAN-13 example.  This EAN barcode is invalid
as the checksum should be `0` and not `7`.

```
$ python test_print.py
Traceback (most recent call last):
  File "test_print.py", line 5, in <module>
    p.barcode('13243546557687', 'EAN13', 64, 2, '', '')
  File "/home/pi/fatt-display/lib/python3.7/site-packages/escpos/escpos.py", line 433, in barcode
    bc=bc,
escpos.exceptions.BarcodeCodeError: No Barcode code was supplied (Barcode '13243546557687' not in a valid format for type 'EAN13')
```

This patch set removes `13243546557687` and replaces it with the valid
number `40063813339310`.

In researching the list of [assigned prefixes issued by
G1][g1-prefixes] there seemed to be no "officially" defined test  prefix, so
this change was made to be minimally invasive using the number from the
existing test cases.

Resolves #350

Affects #176

[g1-prefixes]: https://www.gs1.org/standards/id-keys/company-prefix
[test-code]: https://www.barcodelookup.com/4006381333931
    @brianredbeard
    brianredbeard committed Jun 30, 2019
    Configuration menu
    Copy the full SHA
    c40f2ab View commit details
    Browse the repository at this point in the history

  3. update mailmap-file

    @patkan
    patkan committed Jun 30, 2019
    Configuration menu
    Copy the full SHA
    a68347e View commit details
    Browse the repository at this point in the history
Loading