refactor(test): use shared project fixture in unit tests

amimas · amimas · commit 2adc01590c9a · 2026-03-15T17:53:35.000-04:00
This commit refactors the unit tests for `ProjectFeatureFlag` and
`ProjectFeatureFlagUserList` to use the shared `project` fixture from
`conftest.py`.

This change removes duplicated local fixture definitions, improving
code consistency and maintainability, and addresses feedback from
the pull request review.
diff --git a/tests/unit/objects/test_project_feature_flag_user_lists.py b/tests/unit/objects/test_project_feature_flag_user_lists.py
@@ -2,17 +2,8 @@
 Unit tests for Project Feature Flag User Lists.
 """
 
-import pytest
 import responses
 
-from gitlab import Gitlab
-
-
-@pytest.fixture
-def project():
-    gl = Gitlab("http://localhost", private_token="private_token", api_version="4")
-    return gl.projects.get(1, lazy=True)
-
 
 def test_create_user_list_with_list_conversion(project):
     """
diff --git a/tests/unit/objects/test_project_feature_flags.py b/tests/unit/objects/test_project_feature_flags.py
@@ -2,19 +2,11 @@
 Unit tests for Project Feature Flags.
 """
 
-import pytest
 import responses
 
-from gitlab import Gitlab
 from gitlab.v4.objects import ProjectFeatureFlag
 
 
-@pytest.fixture
-def project():
-    gl = Gitlab("http://localhost", private_token="private_token", api_version="4")
-    return gl.projects.get(1, lazy=True)
-
-
 def test_feature_flag_rename(project):
     """
     Verify that renaming a feature flag uses the old name in the URL
diff --git a/tests/unit/test_types.py b/tests/unit/test_types.py
@@ -124,7 +124,7 @@ def test_lowercase_string_attribute_get_for_api():
     assert o.get_for_api(key="spam") == ("spam", "foo")
 
 
-# JSONAttribute tests
+# JsonAttribute tests
 def test_json_attribute() -> None:
     attr = types.JsonAttribute()
 
