refactor(test): do not overwrite fixture within test logic

amimas · JohnVillalovos · commit 382b12217eae · 2026-03-23T07:13:08.000-07:00
Some test cases overwrote the fixture originally used by the test.
Ideally fixtures shouldn't be overwritten. This change refactored
those tests so that a new variable is used within the test code
instead of using the same name as the fixture.
diff --git a/tests/functional/api/test_project_feature_flags.py b/tests/functional/api/test_project_feature_flags.py
@@ -86,19 +86,19 @@ def test_delete_feature_flag_strategy(project, feature_flag):
     feature_flag.strategies = strategies
     feature_flag.save()
 
-    feature_flag = project.feature_flags.get(feature_flag.name)
-    assert len(feature_flag.strategies) == 2
+    updated_feature_flag = project.feature_flags.get(feature_flag.name)
+    assert len(updated_feature_flag.strategies) == 2
 
     # Remove strategy using _destroy
-    strategies = feature_flag.strategies
-    for strategy in strategies:
+    updated_strategies = updated_feature_flag.strategies
+    for strategy in updated_strategies:
         if strategy["name"] == "userWithId":
             strategy["_destroy"] = True
-    feature_flag.save()
+    updated_feature_flag.save()
 
-    feature_flag = project.feature_flags.get(feature_flag.name)
-    assert len(feature_flag.strategies) == 1
-    assert feature_flag.strategies[0]["name"] == "default"
+    updated_feature_flag = project.feature_flags.get(feature_flag.name)
+    assert len(updated_feature_flag.strategies) == 1
+    assert updated_feature_flag.strategies[0]["name"] == "default"
 
 
 def test_delete_feature_flag_scope(project, feature_flag):
@@ -112,16 +112,16 @@ def test_delete_feature_flag_scope(project, feature_flag):
     feature_flag.strategies = strategies
     feature_flag.save()
 
-    feature_flag = project.feature_flags.get(feature_flag.name)
-    assert len(feature_flag.strategies[0]["scopes"]) == 2
+    updated_feature_flag = project.feature_flags.get(feature_flag.name)
+    assert len(updated_feature_flag.strategies[0]["scopes"]) == 2
 
     # Remove scope using _destroy
-    strategies = feature_flag.strategies
-    for scope in strategies[0]["scopes"]:
+    updated_strategies = updated_feature_flag.strategies
+    for scope in updated_strategies[0]["scopes"]:
         if scope["environment_scope"] == "production":
             scope["_destroy"] = True
-    feature_flag.save()
+    updated_feature_flag.save()
 
-    feature_flag = project.feature_flags.get(feature_flag.name)
-    assert len(feature_flag.strategies[0]["scopes"]) == 1
-    assert feature_flag.strategies[0]["scopes"][0]["environment_scope"] == "*"
+    updated_feature_flag = project.feature_flags.get(feature_flag.name)
+    assert len(updated_feature_flag.strategies[0]["scopes"]) == 1
+    assert updated_feature_flag.strategies[0]["scopes"][0]["environment_scope"] == "*"
