Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: openstack/python-glanceclient
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: redhat-openstack/python-glanceclient
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: stable/juno
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 2 commits
  • 3 files changed
  • 2 contributors

Commits on Jan 13, 2015

  1. Remove runtime dependency on python-pbr.

    Jakub Ruzicka committed Jan 13, 2015
    Configuration menu
    Copy the full SHA
    23af7f2 View commit details
    Browse the repository at this point in the history

Commits on Mar 24, 2015

  1. https: Prevent leaking sockets for some operations 

    Other OpenStack services which instantiate a 'https' glanceclient using
ssl_compression=False and insecure=False (eg Nova, Cinder) are leaking
sockets due to glanceclient not closing the connection to the Glance
server.

This could happen for a sub-set of calls, eg 'show', 'delete', 'update'.

netstat -nopd would show the sockets would hang around forever:

... 127.0.0.1:9292          ESTABLISHED 9552/python      off (0.00/0/0)

urllib's ConnectionPool relies on the garbage collector to tear down
sockets which are no longer in use. The 'verify_callback' function used to
validate SSL certs was holding a reference to the VerifiedHTTPSConnection
instance which prevented the sockets being torn down.

Change-Id: Idb3e68151c48ed623ab89d05d88ea48465429838
Closes-bug: 1423165
(cherry picked from commit ef9fd9f)
    @apevec
    Stuart McLaren authored and apevec committed Mar 24, 2015
    Configuration menu
    Copy the full SHA
    c1ff2ba View commit details
    Browse the repository at this point in the history
Loading