allow eventhandlers and eventspecs for exception handlers #5295
Draft
adhami3310 wants to merge 2 commits intomainfrom
Draft
allow eventhandlers and eventspecs for exception handlers #5295adhami3310 wants to merge 2 commits intomainfrom
adhami3310 wants to merge 2 commits intomainfrom
Conversation
CodSpeed Performance ReportMerging #5295 will not alter performanceComparing Summary
|
masenf
reviewed
May 15, 2025
Collaborator
masenf
left a comment
There was a problem hiding this comment.
both frontend and backend exception handlers need to be able to be specified as EventSpec/EventHandler
| if isinstance(frontend_exception_handler, EventActionsMixin) and callable( | ||
| frontend_exception_handler | ||
| ): | ||
| return frontend_exception_handler(stack) |
Collaborator
There was a problem hiding this comment.
i think we want to avoid the extra round trip to the client for processing this.
is it possible to do something like
await app.event_namespace.on_event(
sid=self.router.session.session_id,
data=fix_events(
events=[frontend_exception_handler(stack)],
token=self.router.session.client_token,
router_data=self.router_data,
)[0],
)
i guess maybe that would have a dead locking issue because the state is already being processed.
Member
Author
There was a problem hiding this comment.
maybe? i couldn't understand exactly how the flow is going and how to make it do that, which is why i couldn't figure out the backend exception and why this one is a draft
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.