Skip to content

chore: Move jobs from lint.yml to style.yml #14922

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
msugakov merged 4 commits into from
Apr 10, 2025
Merged

chore: Move jobs from lint.yml to style.yml #14922

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2e6824e
Copy jobs from `lint.yml` to `style.yml`
msugakov Apr 8, 2025
cd54702
Add old new jobs to `slack-on-style-failure`
msugakov Apr 8, 2025
692f882
Delete `lint.yml` as redundant
msugakov Apr 8, 2025
c8470bb
Pin commit for getting `download-actionlint.bash`
msugakov Apr 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
51 changes: 0 additions & 51 deletions .github/workflows/lint.yml
View file
Open in desktop

This file was deleted.

40 changes: 40 additions & 0 deletions .github/workflows/style.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,6 +197,43 @@ jobs:
image: rhacs-eng/${{ matrix.image }}:${{ steps.image-tag.outputs.image-tag }}-fast
limit: 300

github-actions-lint:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- name: Download actionlint
id: get_actionlint
run: bash <(curl https://raw.githubusercontent.com/rhysd/actionlint/2ab3a12c7848f6c15faca9a92612ef4261d0e370/scripts/download-actionlint.bash) 1.6.27
shell: bash
- name: Check workflow files
run: ${{ steps.get_actionlint.outputs.executable }} -color
shell: bash

github-actions-shellcheck:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- name: Check scripts with shellcheck
run: shellcheck -P SCRIPTDIR -x ./.github/workflows/scripts/*.sh

openshift-ci-lint:
runs-on: ubuntu-latest
container:
image: quay.io/stackrox-io/apollo-ci:stackrox-test-0.4.8
steps:
- name: Checkout
uses: actions/checkout@v4
with:
fetch-depth: 0
ref: ${{ github.event.pull_request.head.sha }}

- uses: ./.github/actions/job-preamble
with:
gcp-account: ${{ secrets.GCP_SERVICE_ACCOUNT_STACKROX_CI }}

- name: Pylint
run: make -C .openshift-ci lint

slack-on-style-failure:
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
Expand All @@ -215,6 +252,9 @@ jobs:
- style-check
- golangci-lint
- check-collector-and-scanner-images-exist
- github-actions-lint
- github-actions-shellcheck
- openshift-ci-lint
permissions:
actions: read
steps:
Expand Down
Loading