Skip to content

ROX-28939: Create GetByQueryFn #15010

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
janisz merged 7 commits into from
Apr 30, 2025
Merged

ROX-28939: Create GetByQueryFn #15010

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
ef72d1b
ROX-28939: create GetByQueryFn
janisz Apr 16, 2025
67ca4ad
deprecate
janisz Apr 16, 2025
643ebd4
generate
janisz Apr 17, 2025
da53522
Update pkg/search/postgres/store.go
janisz Apr 17, 2025
5fbff12
reuse code
janisz Apr 17, 2025
14e1124
add err test
janisz Apr 17, 2025
89f5209
fix
janisz Apr 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions central/activecomponent/datastore/internal/store/postgres/store.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

11 changes: 8 additions & 3 deletions central/administration/events/datastore/internal/store/postgres/store.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 2 additions & 0 deletions central/administration/events/datastore/internal/store/store.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,9 @@ import (
type Store interface {
Count(ctx context.Context, q *v1.Query) (int, error)
Get(ctx context.Context, id string) (*storage.AdministrationEvent, bool, error)
// Deprecated: use GetByQueryFn instead
GetByQuery(ctx context.Context, query *v1.Query) ([]*storage.AdministrationEvent, error)
GetByQueryFn(ctx context.Context, query *v1.Query, fn func(obj *storage.AdministrationEvent) error) error
UpsertMany(ctx context.Context, objs []*storage.AdministrationEvent) error
DeleteMany(ctx context.Context, identifiers []string) error
GetMany(ctx context.Context, identifiers []string) ([]*storage.AdministrationEvent, []int, error)
Expand Down
11 changes: 8 additions & 3 deletions central/administration/usage/store/postgres/store.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

14 changes: 14 additions & 0 deletions central/alert/datastore/internal/store/mocks/store.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

11 changes: 8 additions & 3 deletions central/alert/datastore/internal/store/postgres/store.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

19 changes: 19 additions & 0 deletions central/alert/datastore/internal/store/postgres/store_test.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 2 additions & 0 deletions central/alert/datastore/internal/store/store.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,9 @@ type Store interface {
GetIDs(ctx context.Context) ([]string, error)
Get(ctx context.Context, id string) (*storage.Alert, bool, error)
GetMany(ctx context.Context, ids []string) ([]*storage.Alert, []int, error)
// Deprecated: use GetByQueryFn instead
GetByQuery(ctx context.Context, query *v1.Query) ([]*storage.Alert, error)
GetByQueryFn(ctx context.Context, query *v1.Query, fn func(obj *storage.Alert) error) error
Upsert(ctx context.Context, alert *storage.Alert) error
UpsertMany(ctx context.Context, alerts []*storage.Alert) error
Delete(ctx context.Context, id string) error
Expand Down
14 changes: 14 additions & 0 deletions central/apitoken/datastore/internal/store/mocks/store.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

11 changes: 8 additions & 3 deletions central/apitoken/datastore/internal/store/postgres/store.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 2 additions & 0 deletions central/apitoken/datastore/internal/store/store.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,9 @@ type Store interface {
Search(ctx context.Context, q *v1.Query) ([]search.Result, error)

Get(ctx context.Context, id string) (*storage.TokenMetadata, bool, error)
// Deprecated: use GetByQueryFn instead
GetByQuery(ctx context.Context, query *v1.Query) ([]*storage.TokenMetadata, error)
GetByQueryFn(ctx context.Context, query *v1.Query, fn func(obj *storage.TokenMetadata) error) error
Walk(context.Context, func(*storage.TokenMetadata) error) error
Upsert(context.Context, *storage.TokenMetadata) error
}
9 changes: 6 additions & 3 deletions central/auth/store/postgres/store.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

11 changes: 8 additions & 3 deletions central/authprovider/datastore/internal/store/postgres/store.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

11 changes: 8 additions & 3 deletions central/blob/datastore/store/postgres/store.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

14 changes: 14 additions & 0 deletions central/cloudsources/datastore/internal/store/mocks/store.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

11 changes: 8 additions & 3 deletions central/cloudsources/datastore/internal/store/postgres/store.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 2 additions & 0 deletions central/cloudsources/datastore/internal/store/store.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,9 @@ type Store interface {
Count(ctx context.Context, q *v1.Query) (int, error)
Search(ctx context.Context, q *v1.Query) ([]search.Result, error)
Get(ctx context.Context, id string) (*storage.CloudSource, bool, error)
// Deprecated: use GetByQueryFn instead
GetByQuery(ctx context.Context, query *v1.Query) ([]*storage.CloudSource, error)
GetByQueryFn(ctx context.Context, query *v1.Query, fn func(obj *storage.CloudSource) error) error
Upsert(ctx context.Context, obj *storage.CloudSource) error
Delete(ctx context.Context, id string) error
}
Loading
Loading