Skip to content

ROX-29453: Inactive image retention setting 0 should never prune images #15469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sachaudh merged 1 commit into from
May 29, 2025
Merged

ROX-29453: Inactive image retention setting 0 should never prune images #15469

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions central/pruning/pruning.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -589,6 +589,10 @@
func (g *garbageCollectorImpl) collectImages(config *storage.PrivateConfig) {
defer metrics.SetPruningDuration(time.Now(), "Images")
pruneImageAfterDays := config.GetImageRetentionDurationDays()
if pruneImageAfterDays == 0 {
log.Info("[Image Pruning] pruning is disabled.")
return
}

Check warning on line 595 in central/pruning/pruning.go

View check run for this annotation

Codecov / codecov/patch

central/pruning/pruning.go#L593-L595 

Added lines #L593 - L595 were not covered by tests
qb := search.NewQueryBuilder().AddDays(search.LastUpdatedTime, int64(pruneImageAfterDays)).ProtoQuery()
imageResults, err := g.images.Search(pruningCtx, qb)
if err != nil {
Expand Down
Loading