refactor(tools): extract tools/retest into independent Go module#19401
Draft
refactor(tools): extract tools/retest into independent Go module#19401
Conversation
|
Skipping CI for Draft Pull Request. |
Contributor
There was a problem hiding this comment.
Hey - I've found 1 issue, and left some high level feedback:
- The
goversion intools/retest/go.modis set to1.25.5, which is not a valid released Go version; consider aligning it with the root module’s Go version or the CI Go version used in this repo. - If
save: falsefor.github/actions/cache-go-dependenciesis intended as a permanent default for these workflows, it may be clearer to set this as the default inside the reusable action rather than repeating it across individual jobs.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The `go` version in `tools/retest/go.mod` is set to `1.25.5`, which is not a valid released Go version; consider aligning it with the root module’s Go version or the CI Go version used in this repo.
- If `save: false` for `.github/actions/cache-go-dependencies` is intended as a permanent default for these workflows, it may be clearer to set this as the default inside the reusable action rather than repeating it across individual jobs.
## Individual Comments
### Comment 1
<location path="tools/retest/go.mod" line_range="3" />
<code_context>
+module github.com/stackrox/rox/tools/retest
+
+go 1.25.5
+
+require (
</code_context>
<issue_to_address>
**issue (bug_risk):** The Go version `1.25.5` is not a valid released Go version and will break tooling and CI setup.
This will surface as an `unknown go version` error in both the `go` toolchain and `actions/setup-go`, and will cause the `retest` workflow to fail because it uses `tools/retest/go.mod` as its `go-version-file`. Please update this to a valid released version, ideally matching the root `go.mod` (e.g., `go 1.22.x` or whatever the repo targets).
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
5cb3c16 to
af0a54c
Compare
tools/retest only depends on go-github and has no imports from the main stackrox module. Making it a standalone module means: - Its go.sum only contains 6 dependencies instead of the full monorepo's - The setup-go cache key in retest_periodic.yml is now based on this small go.sum, so it only invalidates when go-github is updated rather than on every repo-wide dependency bump - Removes go-github/v60 from the root go.mod (no other code uses it) Update retest_periodic.yml to use tools/retest/go.mod for Go version and tools/retest/go.sum for cache-dependency-path. Partially generated by AI. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
af0a54c to
97c4d6c
Compare
Contributor
|
Images are ready for the commit at 97c4d6c. To use with deploy scripts, first |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
tools/retestonly depends ongo-githubandtestify, with no imports from the maingithub.com/stackrox/roxmodule. Extracting it into its own Go module means:go.sumcontains only 6 dependencies instead of the full monorepo's ~1000+go-github/v60from the rootgo.mod(no other code imports it)Updates
retest_periodic.ymlto usetools/retest/go.modforgo-version-fileandtools/retest/go.sumforcache-dependency-path.Partially generated by AI.
Testing and quality
How I validated my change
go build ./...andgo test ./...pass intools/retest/as an independent modulego-github/v60retest_periodic.ymlsparse checkout already includestools/retest