ROX-32459: Bump claircore to v1.5.50 to fix node/vm indexing#19422
Draft
ROX-32459: Bump claircore to v1.5.50 to fix node/vm indexing#19422
Conversation
Bump ClairCore to v1.5.50 and switch node index layer paths to normalized file:// URIs so VM/node indexing remains compatible with newer ClairCore URI handling and benefits from /proc access robustness plus correct package-scan error propagation. User request: "update to 1.5.50 and implement the full ACS change for nodeIndexer/ROX-32459 context." AI generated the dependency bump, URI conversion, and tests; user validated scope, selected version direction, and reviewed/corrected requirements during implementation.
Contributor
Author
|
This change is part of the following stack: Change managed by git-spice. |
|
Skipping CI for Draft Pull Request. |
Contributor
|
Images are ready for the commit at f710db5. To use with deploy scripts, first |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR updates node indexing to work with newer ClairCore filesystem URI handling and improves resilience/correctness for the ROX-32459 scenario.
github.com/quay/claircorefromv1.5.44tov1.5.50.file://URIs beforeclaircore.Layer.Init.Why:
file://URI semantics for filesystem layers.v1.5.44include improvements relevant to ROX-32459 context (including filtering problematic filesystem access and package-scanner error propagation behavior).Acknowledgments:
User-facing documentation
Testing and quality
Automated testing
How I validated my change
Confirming the bug is fixed
✅ The fix is a solution to the issue. However, it makes the indexing pretty slow...
Observing performance
The change seem to significantly increase indexing times. Here few observations (still need more data for a conclusion).
Scanning limited root (works)
Scanning full root:
In case multiple agents run in parallel (one daemon, other one-shot), then the running times are very long - I killed one run after 10 minutes of waiting.