ROX-33733: Fix Next action enablement on policy wizard Actions step#19535
Open
ROX-33733: Fix Next action enablement on policy wizard Actions step#19535
Conversation
|
Skipping CI for Draft Pull Request. |
Contributor
|
Images are ready for the commit at 157d8fe. To use with deploy scripts, first |
fc25181 to
157d8fe
Compare
Contributor
Author
|
/test all |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #19535 +/- ##
=======================================
Coverage 49.25% 49.26%
=======================================
Files 2727 2727
Lines 205788 205788
=======================================
+ Hits 101362 101380 +18
+ Misses 96890 96876 -14
+ Partials 7536 7532 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In the policy creation/edit wizard, on the "Policy behavior > Actions" step, selecting "Inform and enforce" as the response method immediately enables the Next button even though no enforcement option (Build, Deploy, or Runtime) has been toggled on. The user can proceed to the Review step and the save button is greyed out, without any feedback as to why. A user then must press the Back button from the Review step and figure it out!
Expected behavior: The Next button should remain disabled until at least one enforcement toggle (Enforce on Build, Enforce on Deploy, or Enforce on Runtime) is enabled when "Inform and enforce" is selected.
User-facing documentation
Testing and quality
Automated testing
How I validated my change
CI + manual (pointing locally built UI to staging).
Screenshot before fix
Inform and Enforce selected, Next button activated without any enforce toggles selected
Screenshots after fix
After Enforce on build toggled on, Next button is activated
